From patchwork Fri Apr 30 17:42:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tissevert X-Patchwork-Id: 29043 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2C20B27BC7E; Fri, 30 Apr 2021 22:54:51 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1988127BC7C for ; Fri, 30 Apr 2021 22:54:50 +0100 (BST) Received: from localhost ([::1]:50722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcb61-0004Jf-3o for patchwork@mira.cbaines.net; Fri, 30 Apr 2021 17:54:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcXUg-0008E8-Ls for guix-patches@gnu.org; Fri, 30 Apr 2021 14:04:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcXUg-0002TZ-Cl for guix-patches@gnu.org; Fri, 30 Apr 2021 14:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lcXUg-0006Oz-AX for guix-patches@gnu.org; Fri, 30 Apr 2021 14:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48126] [PATCH] Add package for vim-solarized Resent-From: Tissevert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Apr 2021 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48126 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48126@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161980583924597 (code B ref -1); Fri, 30 Apr 2021 18:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2021 18:03:59 +0000 Received: from localhost ([127.0.0.1]:59808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcXUc-0006Of-EL for submit@debbugs.gnu.org; Fri, 30 Apr 2021 14:03:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:60576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcXAf-0003i4-P7 for submit@debbugs.gnu.org; Fri, 30 Apr 2021 13:43:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcXAd-0005NQ-B1 for guix-patches@gnu.org; Fri, 30 Apr 2021 13:43:21 -0400 Received: from marvid.fr ([163.172.81.107]:49386 helo=courriel.marvid.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcXAa-0001a9-Gx for guix-patches@gnu.org; Fri, 30 Apr 2021 13:43:18 -0400 Received: from pine.local (unknown [78.194.167.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id 2D10B51E088B for ; Fri, 30 Apr 2021 19:42:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marvid.fr; s=201901; t=1619804556; bh=IfzqcJa+qwcIvkrSlYiSkiThY9sQX59MVOp1N1QC2Ss=; h=Date:From:To:Subject; b=Rb0SdDYcR9zzydtrkQKsfbkIekC0tVOmH2N3nNTv5T1b7E5J7PX2PfbQISOYvyzyZ sVuYjZr9TgD9jAzpoPV8Ge74XeSafa8l3b6dpnufY8IRG5B4m6vuimMfXvmaLyyL6F nDwFcOOJdzyvpQn5RWSE5yzTTaKWPXlbnnvrWkXk= Date: Fri, 30 Apr 2021 19:42:35 +0200 From: Tissevert Message-ID: <20210430194235.1461cada@pine.local> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Received-SPF: pass client-ip=163.172.81.107; envelope-from=tissevert+guix@marvid.fr; helo=courriel.marvid.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 30 Apr 2021 14:03:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Fri, 30 Apr 2021 17:09:33 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Guix ! I here's my first attempt at packaging something, I noticed that vim-solarized was missing so I tried to write a package for it. The only warning I got was from the guix lint which told me it couldn't find upstream releases. I believe this is due to vim-solarized particular structure: it's a light «clone» of the main repository https://github.com/altercation/solarized containing only the vim-files. It doesn't have any tags/releases but the full repository does. I used the latest commit on the master branch in git-reference for guix to retrieve it and the corresponding version on the full repository as package version. Does that seem right ? I found another copy in project vim-scripts (https://github.com/vim-scripts/Solarized) which has made a tag (the same version name that I chose) so we could be using either the full repository (more unneeded data retrieved during the build) or this second copy (they do provide a tag but isn't it better to remain as close as possible to the original source ?). I hope my patch is correct and thank you everyone for being such a welcoming community and having made my experience with Guix so far absolutely great ! Tissevert From 8c6f15a97910d2786968818fc8ecf82a73df24c3 Mon Sep 17 00:00:00 2001 From: Tissevert Date: Fri, 30 Apr 2021 19:04:35 +0200 Subject: [PATCH] Add package for vim-solarized --- gnu/packages/vim.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm index 47ac984fc7..477c15b9aa 100644 --- a/gnu/packages/vim.scm +++ b/gnu/packages/vim.scm @@ -10,6 +10,7 @@ ;;; Copyright © 2019, 2020 Jakub Kądziołka ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2021 Simon Tournier +;;; Copyright © 2021 Tissevert ;;; ;;; This file is part of GNU Guix. ;;; @@ -579,6 +580,30 @@ are detected, the user is notified.") (home-page "https://github.com/vim-syntastic/syntastic") (license license:wtfpl2))) +(define-public vim-solarized + (package + (name "vim-solarized") + (version "v1.0.0beta1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/altercation/vim-colors-solarized") + (commit "528a59f26d12278698bb946f8fb82a63711eec21"))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "05d3lmd1shyagvr3jygqghxd3k8a4vp32723fvxdm57fdrlyzcm1")))) + (build-system copy-build-system) + (arguments + '(#:install-plan + '(("colors" "share/vim/vimfiles/") + ("doc" "share/vim/vimfiles/")))) + (home-page "https://github.com/altercation/vim-colors-solarized") + (synopsis "Solarized Colorscheme for Vim") + (description "Precision colors for machines and people") + (license license:bsd-3))) + (define-public editorconfig-vim (package (name "editorconfig-vim") -- 2.31.1