| Message ID | 20210414102010.6100-5-mjbecze@riseup.net |
|---|---|
| State | New |
| Headers | show |
| Series | Add wally-cli | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
On Wed, 2021-04-14 at 05:20 -0500, Martin Becze wrote: > +(define-public go-github-com-google-gousb > + (package > + (name "go-github-com-google-gousb") > + (version "2.1.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/google/gousb.git") > + (commit (string-append "v" version)))) > + (sha256 > + (base32 > + "1aki6hk009sicrf7gxy5nkjmj4j7lsy0by4kjgd9bwq8ragfyv5x")) > + (file-name (git-file-name name version)))) > + (build-system go-build-system) > + (arguments > + '(#:import-path "github.com/google/gousb")) > + (propagated-inputs > + `(("pkg-config" ,pkg-config) > + ("libusb" ,libusb))) Most likely, "pkg-config" should be in native-inputs. I believe there's a linter that checks whether packages should be in native-inputs, but I'm not sure if pkg-config is detected. Consider running ./pre-inst-env guix lint go-github-com-google-gousb. Also, why is "libusb" in "propagated-inputs" and not in "inputs"? "inputs" is usually preferred over "propagated-inputs", but there are valid reasons to use "propagated-inputs" instead. Greetings, Maime.
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b218f3fa4a..4643859424 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -56,6 +56,7 @@ #:use-module (gnu packages gcc) #:use-module (gnu packages glib) #:use-module (gnu packages lua) + #:use-module (gnu packages libusb) #:use-module (gnu packages mp3) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) @@ -4660,6 +4661,32 @@ GitHub API v3.") create or replace a file or symbolic link.") (license license:asl2.0))) +(define-public go-github-com-google-gousb + (package + (name "go-github-com-google-gousb") + (version "2.1.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/google/gousb.git") + (commit (string-append "v" version)))) + (sha256 + (base32 + "1aki6hk009sicrf7gxy5nkjmj4j7lsy0by4kjgd9bwq8ragfyv5x")) + (file-name (git-file-name name version)))) + (build-system go-build-system) + (arguments + '(#:import-path "github.com/google/gousb")) + (propagated-inputs + `(("pkg-config" ,pkg-config) + ("libusb" ,libusb))) + (home-page "https://github.com/google/gousb") + (synopsis "Wrapping for libusb") + (description "The gousb package is an attempt at wrapping the libusb +library into a Go-like binding.") + (license license:asl2.0))) + (define-public go-golang.org-x-sync-errgroup (let ((commit "cd5d95a43a6e21273425c7ae415d3df9ea832eeb") (revision "0"))