diff mbox series

[bug#47659] gnu: guile-cv: Use guile2.2 version of guile-lib.

Message ID 20210408172526.24437-1-masaya@tojo.tokyo
State Accepted
Headers show
Series [bug#47659] gnu: guile-cv: Use guile2.2 version of guile-lib. | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Masaya Tojo April 8, 2021, 5:25 p.m. UTC 
* gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
guile-lib to guile2.2-lib.
---
 gnu/packages/guile-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

M April 8, 2021, 8:05 p.m. UTC | #1 
On Fri, 2021-04-09 at 02:25 +0900, Masaya Tojo wrote:
> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
> guile-lib to guile2.2-lib.

I believe the current naming convention for guile packages is:

* guile1.8-PACKAGE: for guile@1.8
* guile2.0-PACKAGE: for guile@2.0
* guile2.2-PACKAGE: for guile@2.2
* guile-PACKAGE: for guile@3.0

... though this is not always adhered to.  Basically, ‘we’ want to use
the latest version of guile by default.

So I would suggest:

A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'.  But perhaps
  guile-cv does not (yet) support guile-3.0 (there have been a few incompatible
  2.2 -> 3.0 changes)
or
B: your patch, and rename guile-cv to guile2.2-cv.

Greetings,
Maxime.
Masaya Tojo April 9, 2021, 2:36 p.m. UTC | #2 
Hello,

> A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'.  But perhaps
>   guile-cv does not (yet) support guile-3.0 (there have been a few incompatible
>   2.2 -> 3.0 changes)
> or
> B: your patch, and rename guile-cv to guile2.2-cv.

I tested to build guile-cv with guile-3.0.  But guile-cv's test is
failed, so your suggesion A is not easy.

Therefore, I think suggesion B is better.

Best Regards,

--
Masaya Tojo
Ludovic Courtès April 9, 2021, 3:28 p.m. UTC | #3 
Hi,

Masaya Tojo <masaya@tojo.tokyo> skribis:

> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
> guile-lib to guile2.2-lib.

I agree with Maxime that Guile 3.0 would be best, but in the meantime,
your patch looks like the right thing.

Applied, thanks!

Ludo’.
diff mbox series

Patch

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index e2ee5454a0..75256e0f11 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -28,7 +28,7 @@ 
 ;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us>
 ;;; Copyright © 2020 Julien Lepiler <julien@lepiller.eu>
 ;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
-;;; Copyright © 2020 Masaya Tojo <masaya@tojo.tokyo>
+;;; Copyright © 2020, 2021 Masaya Tojo <masaya@tojo.tokyo>
 ;;; Copyright © 2020 Jesse Gibbons <jgibbons2357@gmail.com>
 ;;; Copyright © 2020 Mike Rosset <mike.rosset@gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at>
@@ -3519,7 +3519,7 @@  feature-set, fully programmable in Guile Scheme.")
                                         texlive-fonts-iwona)))
        ("pkg-config" ,pkg-config)))
     (propagated-inputs
-     `(("guile-lib" ,guile-lib)))
+     `(("guile-lib" ,guile2.2-lib)))
     (home-page "https://www.gnu.org/software/guile-cv/")
     (synopsis "Computer vision library for Guile")
     (description "Guile-CV is a Computer Vision functional programming library