diff mbox series

[bug#46506] system: hurd: Have the static networking provision 'networking.

Message ID 20210214105827.27729-1-mail@cbaines.net
State Accepted
Headers show
Series [bug#46506] system: hurd: Have the static networking provision 'networking. | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Christopher Baines Feb. 14, 2021, 10:58 a.m. UTC 
Some services require networking, I'm looking at the Guix Build Coordinator
agent.  Networking seems to work in the childhurd VM, so I think this change
makes sense.

* gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
parameter for the static-networking service.
---
 gnu/system/hurd.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ludovic Courtès Feb. 22, 2021, 10:06 a.m. UTC | #1 
Hi Chris,

Christopher Baines <mail@cbaines.net> skribis:

> Some services require networking, I'm looking at the Guix Build Coordinator
> agent.  Networking seems to work in the childhurd VM, so I think this change
> makes sense.
>
> * gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
> parameter for the static-networking service.

LGTM, thanks!

Ludo’.
Christopher Baines Feb. 22, 2021, 10:22 p.m. UTC | #2 
Ludovic Courtès <ludo@gnu.org> writes:

> Hi Chris,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Some services require networking, I'm looking at the Guix Build Coordinator
>> agent.  Networking seems to work in the childhurd VM, so I think this change
>> makes sense.
>>
>> * gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
>> parameter for the static-networking service.
>
> LGTM, thanks!

Thanks for taking a look, pushed as
5c7874adb00c834e55e58a9b964ebc5fd1bb872c.
diff mbox series

Patch

diff --git a/gnu/system/hurd.scm b/gnu/system/hurd.scm
index 8b46e65e31..8f3a27834b 100644
--- a/gnu/system/hurd.scm
+++ b/gnu/system/hurd.scm
@@ -79,7 +79,7 @@ 
                  (list (static-networking (interface "lo")
                                           (ip "127.0.0.1")
                                           (requirement '())
-                                          (provision '(loopback))
+                                          (provision '(loopback networking))
                                           (name-servers '("10.0.2.3")))))
         (syslog-service)
         (service guix-service-type