diff mbox series

[bug#46337] A patch to enable building proprietary codecs in qtwebengine

Message ID 20210208154043.65635e9c@runbox.com
State Accepted
Headers show
Series [bug#46337] A patch to enable building proprietary codecs in qtwebengine | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

pkill9 Feb. 8, 2021, 3:40 p.m. UTC 
> Thanks! I tried building with this flag on a powerful computer, but
> the build failed because it couldn't find the dependency openh264.
> That is packaged, so we just need an updated patch.

I've attached an updated patch with the 'openh264' package added to
inputs. Also changed the flag so it's indented using spaces instead of
tabs, which is why it wasn't aligned previously.

Comments

Leo Famulari Feb. 8, 2021, 4:36 p.m. UTC | #1 
On Mon, Feb 08, 2021 at 03:40:43PM +0000, pkill9 wrote:
> From dc0945c1720c74f0a071a8b28b0220e91890ec5c Mon Sep 17 00:00:00 2001
> From: Pkill -9 <pkill9@runbox.com>
> Date: Mon, 8 Feb 2021 15:37:54 +0000
> Subject: [PATCH] gnu/packages/qt.scm: Enable proprietary codecs support (h264)
>  in qtwebengine

Thanks!

It fails like this:

------
[187/187] LINK gn
make[3]: Entering directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/buildtools'
make[3]: Nothing to be done for 'first'.
make[3]: Leaving directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/buildtools'
make[2]: Leaving directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/buildtools'
cd core/ && ( test -e Makefile || /tmp/guix-build-qtwebengine-5.15.2.drv-0/qmake -o Makefile /tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core/core.pro 'QT_B 
make[2]: Entering directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
( test -e Makefile.core_headers || /tmp/guix-build-qtwebengine-5.15.2.drv-0/qmake -o Makefile.core_headers /tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core/ 
make[3]: Entering directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
make[3]: Nothing to be done for 'first'.
make[3]: Leaving directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
( test -e Makefile.core_generator || /tmp/guix-build-qtwebengine-5.15.2.drv-0/qmake -o Makefile.core_generator /tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/c 
make[3]: Entering directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
make[3]: Nothing to be done for 'first'.
make[3]: Leaving directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
( test -e Makefile.gn_run || /tmp/guix-build-qtwebengine-5.15.2.drv-0/qmake -o Makefile.gn_run /tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core/gn_run.pro ' 
Project MESSAGE: Running: /tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/3rdparty/gn/out/Release/gn gen /tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-ev 
Done. Made 12488 targets from 1973 files in 5046ms
make[3]: Entering directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
ninja -k1 -j16  -C /tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core/release QtWebEngineCore
ninja: Entering directory `/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core/release'
ninja: error: '../../3rdparty/chromium/third_party/openh264/src/codec/encoder/core/src/au_set.cpp', needed by 'obj/third_party/openh264/bundled_encoder/au_set.o', missing and no known rule tot
make[3]: *** [Makefile.gn_run:354: run_ninja] Error 1
make[3]: Leaving directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
make[2]: *** [Makefile:82: sub-gn_run-pro-make_first] Error 2
make[2]: Leaving directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src/core'
make[1]: *** [Makefile:80: sub-core-make_first] Error 2
make[1]: Leaving directory '/tmp/guix-build-qtwebengine-5.15.2.drv-0/qtwebengine-everywhere-src-5.15.2/src'
make: *** [Makefile:49: sub-src-make_first] Error 2
command "make" "-j" "16" failed with status 2
builder for `/gnu/store/50f3xngwq0n1vnfxslyhxpqd0yswdxss-qtwebengine-5.15.2.drv' failed with exit code 1
@ build-failed /gnu/store/50f3xngwq0n1vnfxslyhxpqd0yswdxss-qtwebengine-5.15.2.drv - 1 builder for `/gnu/store/50f3xngwq0n1vnfxslyhxpqd0yswdxss-qtwebengine-5.15.2.drv' failed with exit code 1
derivation '/gnu/store/50f3xngwq0n1vnfxslyhxpqd0yswdxss-qtwebengine-5.15.2.drv' offloaded to '141.80.167.174' failed: build of `/gnu/store/50f3xngwq0n1vnfxslyhxpqd0yswdxss-qtwebengine-5.15.2.d
build of /gnu/store/50f3xngwq0n1vnfxslyhxpqd0yswdxss-qtwebengine-5.15.2.drv failed
------
diff mbox series

Patch

From dc0945c1720c74f0a071a8b28b0220e91890ec5c Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Mon, 8 Feb 2021 15:37:54 +0000
Subject: [PATCH] gnu/packages/qt.scm: Enable proprietary codecs support (h264)
 in qtwebengine

---
 gnu/packages/qt.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 4fbb157600..cb4699387d 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -1881,6 +1881,7 @@  using the Enchant spell-checking library.")
        ("mesa" ,mesa)
        ("minizip" ,minizip)
        ("nss" ,nss)
+       ("openh264" ,openh264)
        ("opus" ,opus)
        ("pciutils" ,pciutils)
        ("protobuf" ,protobuf)
@@ -1939,7 +1940,8 @@  using the Enchant spell-checking library.")
                        "--webengine-printing-and-pdf=no"
                        "--webengine-ffmpeg=system"
                        "--webengine-icu=system"
-                       "--webengine-pepper-plugins=no")))))
+                       "--webengine-pepper-plugins=no"
+                       "-webengine-proprietary-codecs")))))
        ;; Tests are disabled due to "Could not find QtWebEngineProcess error"
        ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH
        ;; before running tests.
-- 
2.30.0