mbox

[bug#46277,v2,0/2] gnu: Add fwupd and sort patch list.

Message ID 20210203233032.27932-1-lle-bout@zaclys.net
Headers show

Message

vasilii.smirnov--- via Guix-patches" via Feb. 3, 2021, 11:30 p.m. UTC 
Little oopsie here, duplicated some module imports. Fixed now.

Léo Le Bouter (2):
  gnu: Sort patch list alphabetically.
  gnu: Add fwupd.

 gnu/local.mk                                  | 405 +++++++++---------
 gnu/packages/firmware.scm                     | 120 +++++-
 ...d-option-for-installation-sysconfdir.patch | 161 +++++++
 .../patches/fwupd-do-not-write-to-var.patch   |   8 +
 .../patches/fwupd-installed-tests-path.patch  |  48 +++
 .../fwupd-remove-nonfree-lvfs-repo.patch      | 147 +++++++
 6 files changed, 688 insertions(+), 201 deletions(-)
 create mode 100644 gnu/packages/patches/fwupd-add-option-for-installation-sysconfdir.patch
 create mode 100644 gnu/packages/patches/fwupd-do-not-write-to-var.patch
 create mode 100644 gnu/packages/patches/fwupd-installed-tests-path.patch
 create mode 100644 gnu/packages/patches/fwupd-remove-nonfree-lvfs-repo.patch

Comments

Jonathan Brielmaier Feb. 4, 2021, 11:14 p.m. UTC | #1 
On 04.02.21 00:30, guix-patches--- via wrote:
> Little oopsie here, duplicated some module imports. Fixed now.
>
> Léo Le Bouter (2):
>    gnu: Sort patch list alphabetically.
>    gnu: Add fwupd.

Can you provide a git link (github, gitlab, whatever)? It doesn't really
work with patches send via the mumi interface. Thanks.
Léo Le Bouter Feb. 4, 2021, 11:52 p.m. UTC | #2 
On Fri, 2021-02-05 at 00:14 +0100, Jonathan Brielmaier wrote:
> Can you provide a git link (github, gitlab, whatever)? It doesn't
> really
> work with patches send via the mumi interface. Thanks.

What does not work? I do not host my patches on a git server. Did you
use "git am" and it did not apply?
Léo Le Bouter Feb. 5, 2021, 2:03 a.m. UTC | #3 
On Fri, 2021-02-05 at 00:14 +0100, Jonathan Brielmaier wrote:
> Can you provide a git link (github, gitlab, whatever)? It doesn't
> really
> work with patches send via the mumi interface. Thanks.

I pushed it as branch "lle-bout/add-fwupd" to 
https://git.sr.ht/~lle-bout/guix
Jonathan Brielmaier Feb. 5, 2021, 8:43 a.m. UTC | #4 
On 05.02.21 03:03, Leo Le Bouter wrote:
> On Fri, 2021-02-05 at 00:14 +0100, Jonathan Brielmaier wrote:
>> Can you provide a git link (github, gitlab, whatever)? It doesn't
>> really
>> work with patches send via the mumi interface. Thanks.
>
> I pushed it as branch "lle-bout/add-fwupd" to
> https://git.sr.ht/~lle-bout/guix

Thanks fwupd fails building with:
guix/build/utils.scm:654:6: In procedure invoke:

ERROR:

   1. &invoke-error:

       program:
"/gnu/store/cd5qf3kcnlq35p9k392pjdpdzpsnds70-patch-2.7.6/bin/patch"

       arguments: ("--force" "--no-backup-if-mismatch" "-p1" "--input"
"/gnu/store/lxvqv2gcsp5k098kkcr1r4imbx8hiady-fwupd-remove-nonfree-lvfs-repo.patch")

       exit-status: 1

       term-signal: #f

       stop-signal: #f
Léo Le Bouter Feb. 6, 2021, 12:48 a.m. UTC | #5 
Sorry must've been tired I thought I had tested everything and it was fine.
Some patches conflicted each other, fixed. Now some tests fail, I had tests
disabled previously.

Failing tests lines:

 2/25 fwupd-self-test                         FAIL     0.01 s (killed by signal 6 SIGABRT)
 4/25 fwupdplugin-self-test                   FAIL     2.17 s (killed by signal 6 SIGABRT)
 5/25 fu-self-test                            FAIL     0.47 s (killed by signal 6 SIGABRT)

Run them yourself to see full log, it does not take long. Some tests might use
networking so they'd need to be individually disabled.

Léo Le Bouter (2):
  gnu: Sort patch list alphabetically.
  gnu: Add fwupd.

 gnu/local.mk                                  | 405 +++++++++---------
 gnu/packages/firmware.scm                     | 117 ++++-
 ...d-option-for-installation-sysconfdir.patch | 152 +++++++
 .../patches/fwupd-do-not-write-to-var.patch   |   8 +
 .../patches/fwupd-installed-tests-path.patch  |  48 +++
 .../fwupd-remove-nonfree-lvfs-repo.patch      | 147 +++++++
 6 files changed, 676 insertions(+), 201 deletions(-)
 create mode 100644 gnu/packages/patches/fwupd-add-option-for-installation-sysconfdir.patch
 create mode 100644 gnu/packages/patches/fwupd-do-not-write-to-var.patch
 create mode 100644 gnu/packages/patches/fwupd-installed-tests-path.patch
 create mode 100644 gnu/packages/patches/fwupd-remove-nonfree-lvfs-repo.patch