diff mbox series

[bug#45983,1/3] import: gnu: Add internationalized messages.

Message ID 20210119152737.4344-1-zimon.toutoune@gmail.com
State Accepted
Headers show
Series [bug#45983,1/3] import: gnu: Add internationalized messages. | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Simon Tournier Jan. 19, 2021, 3:27 p.m. UTC 
* guix/import/gnu.scm (gnu->guix-package): Add 'G_' to messages.
---
 guix/import/gnu.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comments

Ludovic Courtès Jan. 26, 2021, 10:14 p.m. UTC | #1 
Hi,

zimoun <zimon.toutoune@gmail.com> skribis:

> * guix/import/gnu.scm (gnu->guix-package): Add 'G_' to messages.

[...]

> -                   (message "couldn't find meta-data for GNU package")))))
> +                   (message
> +                    (format #f
> +                            (G_ "couldn't find meta-data for GNU ~a")
> +                            name))))))
>           (info
>            (gnu-package->sexp info release #:key-download key-download)))))
>      (_
>       (raise (condition
>               (&message
>                (message
> -               "failed to determine latest release of GNU package")))))))
> +               (format #f
> +                       (G_ "failed to determine latest release of GNU ~a")

Please use ‘formatted-message’ instead.

Note that (message "foo") is subject to translation just like (G_
"foo").  See the ‘--keyword’ options in po/guix/Makevars.

Thanks,
Ludo’.
diff mbox series

Patch

diff --git a/guix/import/gnu.scm b/guix/import/gnu.scm
index 29324d7554..fe7a2f1e54 100644
--- a/guix/import/gnu.scm
+++ b/guix/import/gnu.scm
@@ -1,5 +1,6 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014, 2015, 2016 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -19,6 +20,7 @@ 
 (define-module (guix import gnu)
   #:use-module (guix gnu-maintenance)
   #:use-module (guix import utils)
+  #:use-module (guix i18n)
   #:use-module (guix utils)
   #:use-module (guix store)
   #:use-module (gcrypt hash)
@@ -115,13 +117,18 @@  details.)"
          (#f
           (raise (condition
                   (&message
-                   (message "couldn't find meta-data for GNU package")))))
+                   (message
+                    (format #f
+                            (G_ "couldn't find meta-data for GNU ~a")
+                            name))))))
          (info
           (gnu-package->sexp info release #:key-download key-download)))))
     (_
      (raise (condition
              (&message
               (message
-               "failed to determine latest release of GNU package")))))))
+               (format #f
+                       (G_ "failed to determine latest release of GNU ~a")
+                       name))))))))
 
 ;;; gnu.scm ends here