diff mbox series

[bug#45948,2/5] build: test-driver.scm: Define the --test-name option as required.

Message ID 20210118062501.27022-2-maxim.cournoyer@gmail.com
State Accepted
Headers show
Series Improvements to the Automake SRFI 64 test driver. | expand

Commit Message

Maxim Cournoyer Jan. 18, 2021, 6:24 a.m. UTC 
This is clearer than failing to open an empty string file name, when the
option is not provided.

* build-aux/test-driver.scm (%options)[test-name]: Set the required? property
to #t.
---
 build-aux/test-driver.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxim Cournoyer Jan. 18, 2021, 2:37 p.m. UTC | #1 
Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> This is clearer than failing to open an empty string file name, when the
> option is not provided.
>
> * build-aux/test-driver.scm (%options)[test-name]: Set the required? property
> to #t.

I just noticed this doesn't play well with the --help or --version
options.  So this patch should be dropped.

Thanks,

Maxim
diff mbox series

Patch

diff --git a/build-aux/test-driver.scm b/build-aux/test-driver.scm
index b7622c3ed2..5891631da6 100644
--- a/build-aux/test-driver.scm
+++ b/build-aux/test-driver.scm
@@ -39,7 +39,7 @@ 
 The '--test-name', '--log-file' and '--trs-file' options are mandatory.\n"))
 
 (define %options
-  '((test-name                 (value #t))
+  '((test-name                 (value #t) (required? #t))
     (log-file                  (value #t))
     (trs-file                  (value #t))
     (color-tests               (value #t))