| Message ID | 20210104014732.19791-1-rprior@protonmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#45644] gnu: esbuild: Update to 0.8.29. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
On Mon, Jan 04, 2021 at 01:47:34AM +0000, Ryan Prior via Guix-patches via wrote:
> * gnu/packages/web.scm (esbuild): Update to 0.8.29.
Thanks! Pushed as ad2469ec86357b1a46dd63dcd17d5831969d5270.
By the way, your patches show that they are authored by "Ryan Prior via
Guix-patches via <guix-patches@gnu.org>". Is that the correct email
address?
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> By the way, your patches show that they are authored by "Ryan Prior via Guix-patches via guix-patches@gnu.org". Is that the correct email address?
No, the correct email address is rprior@protonmail.com
There's maybe 15 commits in Guix that have that incorrect email address. I'm not sure where it comes from or how to get rid of it. I send my patches by running a command like:
git send-email --to=guix-patches@gnu.org --suppress-cc=self 0001-gnu-esbuild-Update-to-0.8.29.patch
Git has my correct email address:
$ git config user.email
rprior@protonmail.com
So I have to imagine that either Protonmail or your email server are changing the email address.
I don't know if it's possible with the commit-signing system you have in place to rewrite Guix repo history, or whether it would be worth it, but it would be nice to have my actual email on my commits instead of the weird munged one. If there's some behavior I can change to keep it from happening again the future I will certainly be flexible.
One thing I'm going to try (unless there's any objection) is to try sending email through a third party like mailgun instead of using Protonmail's SMTP server. If it's confusing or triggers some kind of fraud prevention mechanism to get e-mails to the list that have my Protonmail address on them but aren't actually from Protonmail's server, then the next thing I could try is to request a gnu.org email address for the purposes of contributing to GNU software.
Let me know what you think!
Ryan
via, Ryan Prior via Guix-patches via 写道： > git send-email --to=guix-patches@gnu.org --suppress-cc=self > 0001-gnu-esbuild-Update-to-0.8.29.patch I (and many others) use git send-email, so it can't be directly to blame. I've never used it with an explicit patch file like that, though, only ‘-<n>’, but that should change little. You shouldn't bother too much with Mailgun & the like, this has nothing to do with Protonmail. > So I have to imagine that either Protonmail or your email server > are changing the email address. Looks like us. It's by design. Mailing lists *have to* change email addresses now. If gnu.org sent out mail to mi^Whundreds of Guix users claiming to be directly from you: From: Ryan Prior <rprior@protonmail.com> it would amount to a poor forgery in this age of DMARC & DKIM. We'd be spamholed into oblivion by every recipient who doesn't go through extra (manual/heuristic) trouble to whitelist known MLs. And rightly so. So instead we munge the From header[0], with a note to make receivers aware of that fact: From: Ryan Prior via Guix-patches via <guix-patches@gnu.org> Resent-From: Ryan Prior <rprior@protonmail.com> But this happens to every mail we resend, not only yours: From: Leo Famulari <leo@xxx> Resent-From: Leo Famulari <leo@xxx> I can't say what went wrong, only that I routinely apply patches from Guix MLs through mu4e and ‘git am’ without trouble. I think. The last ~dozen patches signed off by me seem fine, at least. Leo, does this happen to any guix-patch@ or just Ryan's? > I don't know if it's possible with the commit-signing system you > have in place to rewrite Guix repo history, or whether it would > be worth it, No and no. Sorry. We also can't use .mailmap to rewrite the user-facing address. We'd be mapping all of guix-patches@gnu.org to you. I can't think of a way to fix the past. It's unfortunate, but we'll live. Kind regards, T G-R [0]: We (Mailman?) get this part wrong, however: ‘Fu Barian via <beep@gnu.boop>’ looks cute, but it abuses the format & clutters address books everywhere with the bogus name ‘Fu Barian via’.
Tobias Geerinckx-Rice 写道： > I can't say what went wrong, only that I routinely apply patches > from > Guix MLs through mu4e and ‘git am’ without trouble. I > think. The last > ~dozen patches signed off by me seem fine, at least. ...no idea why I didn't actually test your actual patch that caused this actual question. commit e258898862f38aa9effa33ddae7fc517b0a403f4 (HEAD -> tmp) Author: Ryan Prior via Guix-patches via <guix-patches@gnu.org> gnu: Add picoev. * gnu/packages/networking.scm (picoev): New variable. Signed-off-by: Tobias Geerinckx-Rice <me@tobias.gr> Eh, T G-R
On Mon, Jan 04, 2021 at 06:02:54PM +0100, Tobias Geerinckx-Rice wrote:
> Leo, does this happen to any guix-patch@ or just Ryan's?
I've been noticing it with Ryan, but I don't know for sure if it happens
with anyone else. Sometimes I remember to change Ryan's address,
sometimes I don't.
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index cef1028d34..aa6464767c 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -1487,7 +1487,7 @@ used to validate and fix HTML data.") (define-public esbuild (package (name "esbuild") - (version "0.8.27") + (version "0.8.29") (source (origin (method git-fetch) @@ -1496,7 +1496,7 @@ used to validate and fix HTML data.") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "1n9h6r3q6mik7p5j0cyybh1sdcllig0awbryrx28r03cxv4ip2ij")) + (base32 "142gc21aaqmx0d01vmqsg7zi85pjgi3higr4ba0m52qf3mvxd6as")) (modules '((guix build utils))) (snippet '(begin