mbox

[bug#45565,0/2] Add more r-mlr3 add-ons

Message ID 20201231124608.1090-1-wz@freeshell.de
Headers show

Message

Wiktor Żelazny Dec. 31, 2020, 12:46 p.m. UTC 
A false alarm yesterday regarding the r-mlr3pipelines determinism. I
confused the derivation hash with the build hash. As for r-mlr3ordinal,
the linter reported

./gnu/packages/cran.scm:25616:15: r-mlr3ordinal@0.1.0-9000-0.9febac9: the source file name should contain the package name

I don’t know what “source file name” is referenced here, so I’m
submitting the definition as it is.

Wiktor Żelazny (2):
  gnu: Add r-mlr3pipelines.
  gnu: Add r-mlr3ordinal.

 gnu/packages/cran.scm | 62 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)


base-commit: 67497e20890348ebbd41612e2582b1745a80fec5

Comments

Ricardo Wurmus Dec. 31, 2021, 7:20 p.m. UTC | #1 
Hi Wiktor,

I’m terribly sorry for the delay.  These two patches are fine and
slipped through the cracks.  I updated the packages to the new input
style and pushed them to the “master” branch.

> As for r-mlr3ordinal, the linter reported
>
> ./gnu/packages/cran.scm:25616:15: r-mlr3ordinal@0.1.0-9000-0.9febac9: the source file name should contain the package name
>
> I don’t know what “source file name” is referenced here, so I’m
> submitting the definition as it is.

This is due to the use of git-reference; you need to provide “file-name”
to give a name to the source checkout.  I did this when I applied your
patches.

Thanks for these patches!