mbox

[bug#45362,0/1] rtl8812au-aircrack-ng won't build on Linux 5.10

Message ID 20201222104650.11799-1-mail@davie.li
Headers show

Message

David Dashyan Dec. 22, 2020, 10:46 a.m. UTC 
Hello!  I'm using and recently it stopped building succesfully.
Probably due to kernel update I'm not too sure.

Fix for this was just merged today:
https://github.com/aircrack-ng/rtl8812au/pull/791

I haven't tested it on kernell versions defined in linux.scm.  Do I need to do
it before submitting patch for linux module?

David Dashyan (1):
  rtl8812au-aircrack-ng-linux-module: Update to 62cb003

 gnu/packages/linux.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)


base-commit: 2e7c2dc8fa64442eb5b67670c5533090bebdd7fd

Comments

David Dashyan Dec. 22, 2020, 11 a.m. UTC | #1 
Oops attached wrong pr link..
https://github.com/aircrack-ng/rtl8812au/pull/773

> Hello!  I'm using and recently it stopped building succesfully.
* I'm using rtl8812au-aircrack-ng and recently...
Tobias Geerinckx-Rice Dec. 22, 2020, 12:35 p.m. UTC | #2 
David,

David Dashyan 写道：
> Probably due to kernel update I'm not too sure.

Hah, yes :-)  Same damn upstream change that kept me busy all 
morning.

> Fix for this was just merged today:
> https://github.com/aircrack-ng/rtl8812au/pull/791

At a glance that looks like it should keep working fine on older 
kernels.

> I haven't tested it on kernell versions defined in linux.scm. 
> Do I need to do
> it before submitting patch for linux module?

I would, at least the latest ‘longterm’ release, currently 5.4. 
In this case it built fine.

The project obviously intend to keep backwards compatibility so 
any regressions are theirs to fix & ours to update or patch to.

Pushed with our conventional commit message, please take a 
look[0].

Thanks!

T G-R

[0]: 
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8c66ac72fb0ad01227f196d61a0a7675b6f48d61
David Dashyan Dec. 22, 2020, 5:50 p.m. UTC | #3 
Hello Tobias!

> I would, at least the latest ‘longterm’ release, currently 5.4. In
> this case it built fine.
How do you test it btw?  With guix vm?

> Pushed with our conventional commit message, please take a look[0].
Cool!  Thanks for pointing out