mbox

[bug#44547,0/2] Fix "add" snippet and new "addcl" snippet for cumbersome Common Lisp packages

Message ID 20201110090843.30309-1-mail@ambrevar.xyz
Headers show

Message

Pierre Neidhardt Nov. 10, 2020, 9:08 a.m. UTC 
Commit messages for Common Lisp packages are particularly cumbersome to write
since almost everytime we don't add 1 but 3 new variables.

This snippet should make Lispers' life easier.

Also fix the original "add" snippet to extract name more reliably.

Pierre Neidhardt (2):
  etc: snippets: Fix package name extraction.
  etc: snippets: Prefill Common Lisp package names.

 .../text-mode/guix-commit-message-add-cl-package    | 13 +++++++++++++
 .../text-mode/guix-commit-message-add-package       |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 etc/snippets/text-mode/guix-commit-message-add-cl-package


base-commit: 94585fffb23079fe71110e2bf99782eb4ccfa12b

Comments

Pierre Neidhardt Nov. 20, 2020, 10:26 a.m. UTC | #1 
Hi Guillaume,

what do you think of this patch? :)
Guillaume Le Vaillant Nov. 21, 2020, 9:17 a.m. UTC | #2 
Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Hi Guillaume,
>
> what do you think of this patch? :)

Hi,

I tested the "addcl" snippet with a few packages and it worked pretty
well. The only issue I saw is when the main package name is
"sbcl-cl-xyz", the name of the source package in the commit message
becomes "cl-cl-xyz" instead of "cl-xyz".
Pierre Neidhardt Nov. 21, 2020, 11:03 a.m. UTC | #3 
Good catch, I'll send a fix just now.