mbox

[bug#44433,0/3] gnu: Add solidity.

Message ID 20201104122928.30408-1-mjbecze@riseup.net
Headers show

Message

Martin Becze Nov. 4, 2020, 12:29 p.m. UTC
This adds the Solidity compiler. It also updates Z3 and jsoncpp to versions
needed by Solidity. I tested rebuilding quite a few packages that jsoncpp is a
dependent of but I am not sure how to tests them all.

Martin Becze (3):
  gnu: jsoncpp: Update to 1.9.4
  gnu: z3: Update to 4.8.9.
  gnu: Add solidity.

 gnu/local.mk                                  |  2 +-
 gnu/packages/maths.scm                        |  5 +-
 .../patches/jsoncpp-fix-inverted-case.patch   | 22 -----
 gnu/packages/serialization.scm                |  6 +-
 gnu/packages/solidity.scm                     | 88 +++++++++++++++++++
 5 files changed, 95 insertions(+), 28 deletions(-)
 delete mode 100644 gnu/packages/patches/jsoncpp-fix-inverted-case.patch
 create mode 100644 gnu/packages/solidity.scm

Comments

Christopher Baines Nov. 16, 2020, 10:56 p.m. UTC | #1
Martin Becze <mjbecze@riseup.net> writes:

> This adds the Solidity compiler. It also updates Z3 and jsoncpp to versions
> needed by Solidity. I tested rebuilding quite a few packages that jsoncpp is a
> dependent of but I am not sure how to tests them all.
>
> Martin Becze (3):
>   gnu: jsoncpp: Update to 1.9.4
>   gnu: z3: Update to 4.8.9.
>   gnu: Add solidity.
>
>  gnu/local.mk                                  |  2 +-
>  gnu/packages/maths.scm                        |  5 +-
>  .../patches/jsoncpp-fix-inverted-case.patch   | 22 -----
>  gnu/packages/serialization.scm                |  6 +-
>  gnu/packages/solidity.scm                     | 88 +++++++++++++++++++
>  5 files changed, 95 insertions(+), 28 deletions(-)
>  delete mode 100644 gnu/packages/patches/jsoncpp-fix-inverted-case.patch
>  create mode 100644 gnu/packages/solidity.scm

Hi Martin,

Thanks for the patches, they look good. I've pushed the z3 update to
master, as that didn't have many dependent packages.

As you've noticed, jsoncpp has quite a few dependencies. The current
process to handle changes like this is to push them to the core-updates
branch. I have tried building jsoncpp on core-updates, but I'm having
problems with git, curl and HTTPS support...

I'll hopefully have some more time to investigate further in a bit,

Thanks again,

Chris
Christopher Baines Nov. 18, 2020, 8:17 a.m. UTC | #2
Christopher Baines <mail@cbaines.net> writes:

> Martin Becze <mjbecze@riseup.net> writes:
>
>> This adds the Solidity compiler. It also updates Z3 and jsoncpp to versions
>> needed by Solidity. I tested rebuilding quite a few packages that jsoncpp is a
>> dependent of but I am not sure how to tests them all.
>>
>> Martin Becze (3):
>>   gnu: jsoncpp: Update to 1.9.4
>>   gnu: z3: Update to 4.8.9.
>>   gnu: Add solidity.
>>
>>  gnu/local.mk                                  |  2 +-
>>  gnu/packages/maths.scm                        |  5 +-
>>  .../patches/jsoncpp-fix-inverted-case.patch   | 22 -----
>>  gnu/packages/serialization.scm                |  6 +-
>>  gnu/packages/solidity.scm                     | 88 +++++++++++++++++++
>>  5 files changed, 95 insertions(+), 28 deletions(-)
>>  delete mode 100644 gnu/packages/patches/jsoncpp-fix-inverted-case.patch
>>  create mode 100644 gnu/packages/solidity.scm
>
> Hi Martin,
>
> Thanks for the patches, they look good. I've pushed the z3 update to
> master, as that didn't have many dependent packages.
>
> As you've noticed, jsoncpp has quite a few dependencies. The current
> process to handle changes like this is to push them to the core-updates
> branch. I have tried building jsoncpp on core-updates, but I'm having
> problems with git, curl and HTTPS support...
>
> I'll hopefully have some more time to investigate further in a bit,

Following up on this, I found out that I broke curl HTTPS support on the
core-updates branch, which I've now fixed [1].

1: https://git.savannah.gnu.org/cgit/guix.git/commit/?h=core-updates&id=8a594487700ddd2d6c293cc5e302ce74f3f56b70

With that fixed, I was able to push these branches in to the
core-updates branch, they'll be merged in to master eventually, although
that may take quite a few weeks.

I'll close this bug, feel free to re-open it if you want to use it to
track solidity being available in the master branch.

Thanks again,

Chris