diff mbox series

[bug#44049] build-system/haskell: Disable parallel builds.

Message ID 20201017221006.19515-1-zimon.toutoune@gmail.com
State Accepted
Headers show
Series [bug#44049] build-system/haskell: Disable parallel builds. | expand

Checks

Context Check Description
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Simon Tournier Oct. 17, 2020, 10:10 p.m. UTC 
Fixes <https://bugs.gnu.org/43843>.

PARALLEL-BUILD? introduced by commit 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2
leads to unreproducibility.  Instead of reverting, default is set to #false
which allows user to locally build with parallelism.

* guix/build-system/haskell.scm (haskell-build): Turn off PARALLEL-BUILD? by
default.
---
 guix/build-system/haskell.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)


base-commit: d14221bf65cfbe7f8f5b7cac44132087cab70bf5

Comments

Marius Bakke Oct. 18, 2020, 10:11 p.m. UTC | #1 
zimoun <zimon.toutoune@gmail.com> writes:

> Fixes <https://bugs.gnu.org/43843>.
>
> PARALLEL-BUILD? introduced by commit 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2
> leads to unreproducibility.  Instead of reverting, default is set to #false
> which allows user to locally build with parallelism.
>
> * guix/build-system/haskell.scm (haskell-build): Turn off PARALLEL-BUILD? by
> default.

Thanks!  I shortened the comment a little and pushed to staging in
19d42e0e23a7f90ac2dcc1c279bd23a967ff0314.
diff mbox series

Patch

diff --git a/guix/build-system/haskell.scm b/guix/build-system/haskell.scm
index 8304e3b222..87085a50b0 100644
--- a/guix/build-system/haskell.scm
+++ b/guix/build-system/haskell.scm
@@ -1,6 +1,7 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
 ;;; Copyright © 2020 Timothy Sample <samplet@ngyro.com>
+;;; Copyright © 2020 Simon Tournier <zimon.toutoune@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -115,13 +116,17 @@  version REVISION."
                                (cons name propagated-names))))))
                        extra-directories))))))))
 
+;;; PARALLEL-BUILD? introduced by commit
+;;; 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2 leads to unreproducibility.
+;;; Instead of reverting, default is set to #false which allows user to
+;;; locally build with parallelism. See <http://issues.guix.gnu.org/43843#3>.
 (define* (haskell-build store name inputs
                         #:key source
                         (haddock? #t)
                         (haddock-flags ''())
                         (tests? #t)
                         (test-target "test")
-                        (parallel-build? #t)
+                        (parallel-build? #f)
                         (configure-flags ''())
                         (extra-directories ''())
                         (phases '(@ (guix build haskell-build-system)