mbox

[bug#44029,0/4] lxqt-desktop-service-type

Message ID 20201016144000.04a245db@pantherx.org
Headers show

Message

Reza Alizadeh Majd Oct. 16, 2020, 11:10 a.m. UTC 
Hello Guix,

Just prepared a new service definition for LXQt desktop environment.

following changes had been applied:

- update xsession desktop entry and fix session start path to allow GDM
  load the LXQt session properly.
- wrap lxqt-session executable to load custom paths used by LXQt for
  it's default configurations, from system profile (inspired by a
  similar approach followed in NixOS:
  https://github.com/NixOS/nixpkgs/blob/580aede978ba53316a86c4f48990b047b0e67335/nixos/modules/services/x11/desktop-managers/lxqt.nix#L45)
- fix pcmanfm-qt's settings file to load default wallpaper from proper
  location.
- add definition for LXQt desktop environment in gnu/service/desktop.scm

Comments

Reza Alizadeh Majd Oct. 20, 2020, 7:33 a.m. UTC | #1 
On Tue, 20 Oct 2020 00:25:20 +0300
Oleg Pykhalov <go.wigust@gmail.com> wrote:

> Hello,
> 
> Thank you!
> 
> 
> I pushed your patches with minor fixes in Git messages according to
> ChangeLog format [1] and added a paragraph to the Guix documentation.
> 
> [1] https://www.gnu.org/prep/standards/html_node/Change-Logs.html
> [2]
> https://git.savannah.gnu.org/cgit/guix.git/commit?id=764d896668aa0f69514ef22de005fbf851949969
> https://git.savannah.gnu.org/cgit/guix.git/commit?id=807353fe143a6fdb6d6fc96885f6467bc81c24c3
> https://git.savannah.gnu.org/cgit/guix.git/commit?id=bdb030a7dc5bf84365d7f77935e838f848e02786
> https://git.savannah.gnu.org/cgit/guix.git/commit?id=9aa35795d3379de2ee2f0a6fffae61331a4da344
> 
> 
> Oleg.

Thank you!

and sorry about commit messages issue, maybe because of my bad English
writing skills. I'll try to be more accurate according to ChangeLog
format from now on.

Regards,
Reza