| Message ID | 20201008224545.GA1533@andel |
|---|---|
| Headers | show |
On Thu, Oct 08, 2020 at 07:45:45PM -0300, André Batista wrote: > Hello, > > This patch series adds rust-dialoguer-0.3 which is a dependency for > wasm-pack. Unfortunately, one test is failing for this version and > I couldn't figure how to disable it without the hammer. Attached are > the logs for the test failures. It is missing a trait implementation > before usage, but src/prompts.rs appears to implement it. Maybe it > is the default impl that is lacking. > > ---- > > For more information about this error, try `rustc --explain E0277`. > Couldn't compile the test. > > failures: > src/prompts.rs - prompts::Input (line 35) > > test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out > > error: test failed, to rerun pass '--doc' > command "cargo" "test" "--release" failed with status 101 > > ---- I'm not sure how you managed to build it, when I tried I got an error about parking-lot-core@0.5 having the wrong inputs. Luckily it was looking for <1.0.0 so I put in 0.11 and that one was more happy. Looking at the .travis.yml it looks like they only test with the --lib flag, so I removed skip-build and added cargo-test-flags '("--lib"). I was able to build rust-tempfile-2 without any problems, so I took out the skip-build option. Patches pushed! Thanks.
Hello Efraim, dom 11 out 2020 às 13:58:34 (1602435514), efraim@flashner.co.il enviou: > I'm not sure how you managed to build it, when I tried I got an error > about parking-lot-core@0.5 having the wrong inputs. Luckily it was > looking for <1.0.0 so I put in 0.11 and that one was more happy. I was building from a different local working tree, where I had defined other packages, including parking-lot-core, so I guess I did not remember every change I had made and I did not test on the master tree but on my local tree. From now on, I'll be sure to move those definitions one at a time when trying to build to avoid further problems. > Looking at the .travis.yml it looks like they only test with the --lib > flag, so I removed skip-build and added cargo-test-flags '("--lib"). > > I was able to build rust-tempfile-2 without any problems, so I took out > the skip-build option. > > Patches pushed! Thanks. Nice, thank you for pointing that out.
Hello, This patch series adds rust-dialoguer-0.3 which is a dependency for wasm-pack. Unfortunately, one test is failing for this version and I couldn't figure how to disable it without the hammer. Attached are the logs for the test failures. It is missing a trait implementation before usage, but src/prompts.rs appears to implement it. Maybe it is the default impl that is lacking. ---- For more information about this error, try `rustc --explain E0277`. Couldn't compile the test. failures: src/prompts.rs - prompts::Input (line 35) test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out error: test failed, to rerun pass '--doc' command "cargo" "test" "--release" failed with status 101 ----