diff mbox series

[bug#43525] gnu: Add antlr4.

Message ID 20200920031817.1ff59225@tachikoma.lepiller.eu
State Accepted
Headers show
Series [bug#43525] gnu: Add antlr4. | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job

Commit Message

Julien Lepiller Sept. 20, 2020, 1:18 a.m. UTC
Hi Guix!

I tried to update groovy to its latest version today, so here's a patch
series that adds ANTLR 4 instead :p (it's a build dependency for the
newest version of groovy).

Comments

Ricardo Wurmus Sept. 20, 2020, 6:59 a.m. UTC | #1
Hi Julien,

> +         (add-before 'check 'remove-graphemes
> +           (lambda _
> +             ;; When running antlr on grahemes.g4, we get a runtime exception:
> +             ;; set is empty. So delete the file that depends on it.
> +             (delete-file "runtime-testsuite/test/org/antlr/v4/test/runtime/java/api/perf/TimeLexerSpeed.java")))

Please let the phase end on #t.  Please also use double spacing in
comments.

> +         (add-before 'build 'generate-unicode
> +           (lambda _
> +             ;; First: build the generator
> +             (invoke "javac" "-cp" (getenv "CLASSPATH")
> +                     "tool/src/org/antlr/v4/unicode/UnicodeRenderer.java"
> +                     "tool/src/org/antlr/v4/unicode/UnicodeDataTemplateController.java")
> +             ;; Then use it
> +             (invoke "java" "-cp" (string-append (getenv "CLASSPATH")
> +                                                 ":tool/src:runtime/Java")
> +                     "org.antlr.v4.unicode.UnicodeRenderer"
> +                     "tool/resources/org/antlr/v4/tool/templates"
> +                     "unicodedata"
> +                     "tool/src/org/antlr/v4/unicode/UnicodeData.java")
> +             (begin
> +               ;; It seems there is a bug with our ST4
> +               (substitute* "tool/src/org/antlr/v4/unicode/UnicodeData.java"
> +                 (("\\\\>") ">"))
> +               ;; Remove the additional file
> +               (delete-file "tool/src/org/antlr/v4/unicode/UnicodeRenderer.java")
> +               #t)))

Why have a BEGIN here?

> +         (add-before 'build 'generate-grammar
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (with-directory-excursion "tool/src/org/antlr/v4/parse"
> +               (for-each (lambda (file)
> +                           (format #t "~a\n" file)

I’m not sure this actually outputs anything.  Does it?  I’m not a fan of
using FORMAT when DISPLAY would work just fine.

> +                           (system* "antlr3" file))

Why not INVOKE?

> +                         '("ANTLRLexer.g" "ANTLRParser.g" "BlockSetTransformer.g"
> +                           "GrammarTreeVisitor.g" "ATNBuilder.g"
> +                           "ActionSplitter.g" "LeftRecursiveRuleWalker.g")))
> +             (with-directory-excursion "tool/src/org/antlr/v4/codegen"
> +               (copy-file "../parse/ANTLRParser.tokens" "ANTLRParser.tokens")

You can use INSTALL-FILE to avoid having to restate the target file name.

> +               (format #t "SourceGenTriggers.g\n")

How about DISPLAY here?
Julien Lepiller Sept. 20, 2020, noon UTC | #2
Pushed as 1d630fe0f64d16d7428a78ee4bf94e8179ce4a94 to
f9a6e3894b1648e32371e1916dfdf820de496050, thank you!
diff mbox series

Patch

From 7141f332ac488f52de4674a4cb9e6079ebb9ba97 Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Sun, 20 Sep 2020 03:09:23 +0200
Subject: [PATCH 3/3] gnu: Add antlr4.

* gnu/packages/java.scm (antlr4): New variable.
---
 gnu/packages/java.scm | 158 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 158 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index b3a0bfcb65..cc0ef1a759 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -8211,6 +8211,164 @@  actual rendering.")
 sources by ANTLR.")
     (license license:bsd-3)))
 
+(define-public antlr4
+  (package
+    (inherit java-antlr4-runtime)
+    (name "antlr4")
+    (arguments
+     `(#:jar-name "antlr4.jar"
+       #:source-dir "tool/src"
+       #:test-dir "tool-testsuite/test:runtime-testsuite/test:runtime-testsuite/annotations/src"
+       #:test-include (list "**/Test*.java")
+       #:test-exclude (list
+                        ;; no runnable method
+                        "**/TestOutputReading.java"
+                        ;; no @Test methods
+                        "**/TestParserErrors.java"
+                        "**/TestSemPredEvalParser.java"
+                        "**/TestSets.java"
+                        "**/TestListeners.java"
+                        "**/TestParseTrees.java"
+                        "**/TestParserExec.java"
+                        "**/TestLexerErrors.java"
+                        "**/TestPerformance.java"
+                        "**/TestCompositeParsers.java"
+                        "**/TestLexerExec.java"
+                        "**/TestSemPredEvalLexer.java"
+                        "**/TestLeftRecursion.java"
+                        "**/TestFullContextParsing.java"
+                        "**/TestCompositeLexers.java"
+                        ;; Null pointer exception
+                        "**/TestCompositeGrammars.java"
+                        ;; Wrong assumption on emoji
+                        "**/TestUnicodeData.java")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'fix-build.xml
+           (lambda _
+             ;; tests are not in a java subdirectory
+             (substitute* "build.xml"
+               (("\\$\\{test.home\\}/java") "${test.home}"))
+             #t))
+         ;; tests require to have a working antlr4 binary
+         (delete 'check)
+         (add-after 'bin-install 'check
+           (lambda _
+             (invoke "ant" "compile-tests")
+             (invoke "ant" "check" "-Dtest.home=runtime-testsuite/annotations/src")
+             (invoke "ant" "check" "-Dtest.home=runtime-testsuite/test")
+             (invoke "ant" "check" "-Dtest.home=tool-testsuite/test")))
+         (add-before 'check 'remove-unrelated-languages
+           (lambda _
+             ;; There are tests for other languages that ANTLR can generate, but
+             ;; we don't have the infrastructure for that yet.  Let's test Java
+             ;; generation only.
+             (for-each
+               (lambda (language)
+                 (delete-file-recursively
+                   (string-append "runtime-testsuite/test/org/antlr/v4/test/runtime/"
+                                  language)))
+               '("cpp" "csharp" "go" "javascript" "php" "python" "python2"
+                 "python3" "swift"))
+             #t))
+         (add-before 'check 'generate-test-parsers
+           (lambda* (#:key outputs #:allow-other-keys)
+             (define (run-antlr dir filename package)
+               (invoke "antlr4" "-lib" dir "-visitor" "-no-listener"
+                       "-package" package (string-append dir "/" filename)
+                       "-Xlog"))
+             (setenv "PATH" (string-append (getenv "PATH") ":"
+                                           (assoc-ref outputs "out") "/bin"))
+             (run-antlr "runtime-testsuite/test/org/antlr/v4/test/runtime/java/api"
+                        "Java.g4" "org.antlr.v4.test.runtime.java.api")
+             (run-antlr "runtime-testsuite/test/org/antlr/v4/test/runtime/java/api"
+                        "VisitorBasic.g4" "org.antlr.v4.test.runtime.java.api")
+             (run-antlr "runtime-testsuite/test/org/antlr/v4/test/runtime/java/api"
+                        "VisitorCalc.g4" "org.antlr.v4.test.runtime.java.api")
+             #t))
+         (add-before 'check 'remove-graphemes
+           (lambda _
+             ;; When running antlr on grahemes.g4, we get a runtime exception:
+             ;; set is empty. So delete the file that depends on it.
+             (delete-file "runtime-testsuite/test/org/antlr/v4/test/runtime/java/api/perf/TimeLexerSpeed.java")))
+         (add-after 'install 'bin-install
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((jar (string-append (assoc-ref outputs "out") "/share/java"))
+                   (bin (string-append (assoc-ref outputs "out") "/bin")))
+               (mkdir-p bin)
+               (with-output-to-file (string-append bin "/antlr4")
+                 (lambda _
+                   (display
+                     (string-append "#!" (which "sh") "\n"
+                                    "java -cp " jar "/antlr4.jar:"
+                                    (string-join
+                                      (apply
+                                        append
+                                        (map
+                                          (lambda (input)
+                                            (find-files (assoc-ref inputs input)
+                                                  ".*\\.jar"))
+                                          '("antlr3" "java-stringtemplate"
+                                            "java-antlr4-runtime" "java-treelayout"
+                                            "java-jsonp-api" "java-icu4j")))
+                                      ":")
+                                    " org.antlr.v4.Tool $*"))))
+               (chmod (string-append bin "/antlr4") #o755)
+               #t)))
+         (add-before 'build 'copy-resources
+           (lambda _
+             (copy-recursively "tool/resources/" "build/classes")
+             #t))
+         (add-before 'build 'generate-unicode
+           (lambda _
+             ;; First: build the generator
+             (invoke "javac" "-cp" (getenv "CLASSPATH")
+                     "tool/src/org/antlr/v4/unicode/UnicodeRenderer.java"
+                     "tool/src/org/antlr/v4/unicode/UnicodeDataTemplateController.java")
+             ;; Then use it
+             (invoke "java" "-cp" (string-append (getenv "CLASSPATH")
+                                                 ":tool/src:runtime/Java")
+                     "org.antlr.v4.unicode.UnicodeRenderer"
+                     "tool/resources/org/antlr/v4/tool/templates"
+                     "unicodedata"
+                     "tool/src/org/antlr/v4/unicode/UnicodeData.java")
+             (begin
+               ;; It seems there is a bug with our ST4
+               (substitute* "tool/src/org/antlr/v4/unicode/UnicodeData.java"
+                 (("\\\\>") ">"))
+               ;; Remove the additional file
+               (delete-file "tool/src/org/antlr/v4/unicode/UnicodeRenderer.java")
+               #t)))
+         (add-before 'build 'generate-grammar
+           (lambda* (#:key inputs #:allow-other-keys)
+             (with-directory-excursion "tool/src/org/antlr/v4/parse"
+               (for-each (lambda (file)
+                           (format #t "~a\n" file)
+                           (system* "antlr3" file))
+                         '("ANTLRLexer.g" "ANTLRParser.g" "BlockSetTransformer.g"
+                           "GrammarTreeVisitor.g" "ATNBuilder.g"
+                           "ActionSplitter.g" "LeftRecursiveRuleWalker.g")))
+             (with-directory-excursion "tool/src/org/antlr/v4/codegen"
+               (copy-file "../parse/ANTLRParser.tokens" "ANTLRParser.tokens")
+               (format #t "SourceGenTriggers.g\n")
+               (invoke "antlr3" "SourceGenTriggers.g"))
+             #t)))))
+    (inputs
+     `(("antlr3" ,antlr3)
+       ("java-antlr4-runtime" ,java-antlr4-runtime)
+       ("java-icu4j" ,java-icu4j)
+       ("java-jsonp-api" ,java-jsonp-api)
+       ("java-stringtemplate" ,java-stringtemplate)
+       ("java-treelayout" ,java-treelayout)))
+    (native-inputs
+     `(("java-junit" ,java-junit)))
+    (synopsis "Parser and lexer generator in Java")
+    (description "ANTLR (ANother Tool for Language Recognition) is a powerful
+parser generator for reading, processing, executing, or translating structured
+text or binary files.  It's widely used to build languages, tools, and
+frameworks.  From a grammar, ANTLR generates a parser that can build and walk
+parse trees.")))
+
 (define-public java-commons-cli-1.2
   ;; This is a bootstrap dependency for Maven2.
   (package
-- 
2.28.0