| Message ID | 20200904153824.27164-1-mike@rohleder.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#43204] gnu: taglib: Propagate zlib. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
Hi Michael, Michael Rohleder writes: > * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs]. > --- > It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz > according to the installed pkg-config. > > I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib, > (I guess, all revdeps of taglib that don't have zlib as an input have that problem) Oh, indeed emacs-emms doesn't build, sorry for the breakage! :-/ I see the pkg-config file was changed here https://github.com/taglib/taglib/commit/ef1312d62239f399c40233d76ef3328b8dadf984 Propagating zlib seems like the right thing to do (although I'm not a maintainer), thanks for the patch! Pierre
Pierre Langlois writes: > Hi Michael, > > Michael Rohleder writes: > >> * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs]. >> --- >> It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz >> according to the installed pkg-config. >> >> I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib, >> (I guess, all revdeps of taglib that don't have zlib as an input have that problem) > > Oh, indeed emacs-emms doesn't build, sorry for the breakage! :-/ I see > the pkg-config file was changed here https://github.com/taglib/taglib/commit/ef1312d62239f399c40233d76ef3328b8dadf984 > > Propagating zlib seems like the right thing to do (although I'm not a > maintainer), thanks for the patch! Actually, thinking about this a little more, I'm not sure I understand upstream decision to propagate -lz. The commit fixes [0] which indicates it's so that taglib can be linked statically, but then that means if we're dynamically linking, the application will also dynamically link with zlib when it doesn't need to (at least not directly). And in guix we only build shared libs for taglib so we're never statically linking it AFAIK. So, here I'm a bit torn here, should we just follow what upstream is indicating? Even it doesn't look right to me, but I might be wrong! Or, should we revert the change that propagates -lz? Thanks, Pierre [0]: https://github.com/taglib/taglib/issues/872
diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 7ee009df74..8ea282be97 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -175,7 +175,7 @@ a highly stable and efficient implementation.") (arguments '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on. #:configure-flags (list "-DBUILD_SHARED_LIBS=ON"))) - (inputs `(("zlib" ,zlib))) + (propagated-inputs `(("zlib" ,zlib))) (home-page "https://taglib.org") (synopsis "Library to access audio file meta-data") (description