| Message ID | 20200830075025.17460-1-mike@rohleder.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#43108] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
Hello Michael, > My ert-runner fu is not good enough for a better hack. I tried > '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it > skipped all tests then. Well your hack seems to work fine :) Pushed as a73ccefe315cd16e9d0b31a00bbd61e6cc3042f5. Thanks, Mathieu
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c6d95d9b83..cfc728b53e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -14825,7 +14825,17 @@ continue.") ("emacs-undercover" ,emacs-undercover))) (arguments `(#:tests? #t - #:test-command '("ert-runner"))) + #:test-command '("ert-runner") + #:phases + (modify-phases %standard-phases + (add-before 'check 'disable-refs-next-match-test + ;; Hack to disable the failing test for emacs27 + ;; https://github.com/Wilfred/elisp-refs/issues/29 + (lambda _ + (substitute* "test/unit-test.el" + (("ert-deftest elisp-refs-next-match") + "defun elisp-refs-next-match")) + #t))))) (home-page "https://github.com/Wilfred/elisp-refs") (synopsis "Find callers of elisp functions or macros") (description "Find references to functions, macros or variables. Unlike a
* gnu/packages/emacs-xyz.scm (emacs-elisp-refs)[arguments]: Add phase to disable failing test "elisp-refs-next-match" on emacs27. --- My ert-runner fu is not good enough for a better hack. I tried '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it skipped all tests then. gnu/packages/emacs-xyz.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)