diff mbox

[bug#42037,0/3] gnu: lxqt-build-tools: Update to 0.7.0.

Message ID 20200624195250.GA20387@andel
State Accepted
Headers show

Commit Message

André Batista June 24, 2020, 7:52 p.m. UTC
Hello Guix,

This patch series fixes recent build problems when building
lxqt-config by updating this package and its dependencies.

Built with --rounds=2 on x86_64.

---
From aa6bd87fe62db12120146b93a19b036445a10bc2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Wed, 24 Jun 2020 16:23:04 -0300
Subject: [PATCH] gnu: lxqt-build-tools: Update to 0.7.0.
To: guix-devel@gnu.org

* gnu/packages/lxqt.scm (lxqt-build-tools): Update to 0.7.0.
---
 gnu/packages/lxqt.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ludovic Courtès June 25, 2020, 10:28 a.m. UTC | #1
Hi,

Andre Batista <nandre@riseup.net> skribis:

> This patch series fixes recent build problems when building
> lxqt-config by updating this package and its dependencies.

After applying the patches, “guix build lxqt” fails:

--8<---------------cut here---------------start------------->8---
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:428:35: error: no matching function for call to ‘QConcatenable<char [14]>::appendTo(const char [14], Q
Char*&)’
         QConcatenable<A>::appendTo(p.a, out);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note: candidate: static void QConcatenable<const char [N]>::appendTo(const char*, char*&) [wit
h int N = 14]
     static inline void appendTo(const char a[N], char *&out)
                        ^~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note:   no known conversion for argument 2 from ‘QChar*’ to ‘char*&’
exporting path `/gnu/store/x5jzmg1q7ivk5jaqqvr16q2iq5w4yr3l-libexif-0.6.22'
make[2]: *** [CMakeFiles/compton-conf.dir/build.make:213: CMakeFiles/compton-conf.dir/compton-conf.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstring.h:2079:0,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qobject.h:47,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtWidgets/qwidget.h:45,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtWidgets/qdialog.h:44,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtWidgets/QDialog:1,
                 from /tmp/guix-build-compton-conf-0.14.1.drv-0/compton-conf-0.14.1/maindialog.h:24,
                 from /tmp/guix-build-compton-conf-0.14.1.drv-0/compton-conf-0.14.1/maindialog.cpp:21:
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h: In instantiation of ‘static void QConcatenable<QStringBuilder<A, B> >::appendTo(const type&, T*&) [with T = QChar; A = char [25]; B = QString; QConcatenable<QStringBuilder<A, B> >::type = QStringBuilder<char [25], QString>]’:
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:118:56:   required from ‘T QStringBuilder<A, B>::convertTo() const [with T = QString; A = char [25]; B = QString]’
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:131:61:   required from ‘QStringBuilder<A, B>::operator QStringBuilder<A, B>::ConvertTo() const [with A = char [25]; B = QString; QStringBuilder<A, B>::ConvertTo = QString]’
/tmp/guix-build-compton-conf-0.14.1.drv-0/compton-conf-0.14.1/maindialog.cpp:174:57:   required from here
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:428:35: error: no matching function for call to ‘QConcatenable<char [25]>::appendTo(const char [25], QChar*&)’
         QConcatenable<A>::appendTo(p.a, out);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note: candidate: static void QConcatenable<const char [N]>::appendTo(const char*, char*&) [with int N = 25]
     static inline void appendTo(const char a[N], char *&out)
                        ^~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note:   no known conversion for argument 2 from ‘QChar*’ to ‘char*&’
make[2]: *** [CMakeFiles/compton-conf.dir/build.make:200: CMakeFiles/compton-conf.dir/maindialog.cpp.o] Error 1
make[2]: Leaving directory '/tmp/guix-build-compton-conf-0.14.1.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/compton-conf.dir/all] Error 2
make[1]: Leaving directory '/tmp/guix-build-compton-conf-0.14.1.drv-0/build'
make: *** [Makefile:133: all] Error 2
command "make" "-j" "8" failed with status 2
builder for `/gnu/store/2wn9m74y4qjsmywlgy90rd09i39vb2nn-compton-conf-0.14.1.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

Maybe all the lxqt packages should be upgraded in lockstep?

If that is the case, it’s better to upgrade them in a single commit,
such that there are no intermediate commits where things fail to build.

Thanks,
Ludo’.
diff mbox

Patch

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index f9c757a804..9db911f417 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -126,7 +126,7 @@  to statistics about the system on which it's run.")
 (define-public lxqt-build-tools
   (package
     (name "lxqt-build-tools")
-    (version "0.6.0")
+    (version "0.7.0")
     (source
      (origin
        (method url-fetch)
@@ -134,7 +134,7 @@  to statistics about the system on which it's run.")
                            "/download/" version
                            "/lxqt-build-tools-" version ".tar.xz"))
        (sha256
-        (base32 "0n0p0mf12n9f7zm2592779rpqrbcamfdz87nnjb8j058bc8g3214"))))
+        (base32 "147vdkc25mrlr0fy785yzwhm4gwjxa5xl3n3hljz4c97m531kzl5"))))
     (build-system cmake-build-system)
     (arguments
      `(#:tests? #f                      ; no tests