diff mbox series

[bug#42024] nix: Tweak .gitignore files.

Message ID 20200623172717.10275-1-mail@cbaines.net
State Accepted
Headers show
Series [bug#42024] nix: Tweak .gitignore files. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Christopher Baines June 23, 2020, 5:27 p.m. UTC 
Remove .gitignore entries where they match source files that are tracked in
Git.  This is relevant to me at least, as some code searching tools use
.gitignore files and will ignore matched files.

* nix/boost/.gitignore: Delete this file.
* nix/libutils/.gitignore: Delete this file.
* nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
(/schema.sql.hh): New entry.
---
 nix/boost/.gitignore    | 3 ---
 nix/libstore/.gitignore | 3 +--
 nix/libutil/.gitignore  | 2 --
 3 files changed, 1 insertion(+), 7 deletions(-)
 delete mode 100644 nix/boost/.gitignore
 delete mode 100644 nix/libutil/.gitignore

Comments

Ludovic Courtès June 23, 2020, 9:14 p.m. UTC | #1 
Christopher Baines <mail@cbaines.net> skribis:

> Remove .gitignore entries where they match source files that are tracked in
> Git.  This is relevant to me at least, as some code searching tools use
> .gitignore files and will ignore matched files.
>
> * nix/boost/.gitignore: Delete this file.
> * nix/libutils/.gitignore: Delete this file.
> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
> (/schema.sql.hh): New entry.

LGTM!  I don’t know what the rationale was.

BTW, no need to bother with ChangeLog entries for this.

Ludo’.
Christopher Baines June 24, 2020, 7 p.m. UTC | #2 
Ludovic Courtès <ludo@gnu.org> writes:

> Christopher Baines <mail@cbaines.net> skribis:
>
>> Remove .gitignore entries where they match source files that are tracked in
>> Git.  This is relevant to me at least, as some code searching tools use
>> .gitignore files and will ignore matched files.
>>
>> * nix/boost/.gitignore: Delete this file.
>> * nix/libutils/.gitignore: Delete this file.
>> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
>> (/schema.sql.hh): New entry.
>
> LGTM!  I don’t know what the rationale was.
>
> BTW, no need to bother with ChangeLog entries for this.

Great, I've removed the ChangeLog entries and pushed this as
cd43b55da7ab51c996a7a3449c78f2a493616106.

Thanks,

Chris
diff mbox series

Patch

diff --git a/nix/boost/.gitignore b/nix/boost/.gitignore
deleted file mode 100644
index 1f188e3b65..0000000000
--- a/nix/boost/.gitignore
+++ /dev/null
@@ -1,3 +0,0 @@ 
-*.hpp
-*.cpp
-*.cc
diff --git a/nix/libstore/.gitignore b/nix/libstore/.gitignore
index 512a0d022f..805301d6d7 100644
--- a/nix/libstore/.gitignore
+++ b/nix/libstore/.gitignore
@@ -1,3 +1,2 @@ 
-*.cc
-*.hh
 /schema.sql
+/schema.sql.hh
diff --git a/nix/libutil/.gitignore b/nix/libutil/.gitignore
deleted file mode 100644
index e539428b1b..0000000000
--- a/nix/libutil/.gitignore
+++ /dev/null
@@ -1,2 +0,0 @@ 
-*.cc
-*.hh