diff mbox series

[bug#41875] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS.

Message ID 20200615162328.25429-1-brice@waegenei.re
State Accepted
Headers show
Series [bug#41875] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Brice Waegeneire June 15, 2020, 4:23 p.m. UTC 
* gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.
---

Without it 'newgrp' is unusable:

--8<---------------cut here---------------start------------->8---
$ whoami
bricewge
$ cat /etc/group | grep wireshark
wireshark:x:970:bricewge
$ groups
users libvirt adbusers plugdev kvm lp netdev audio video input dialout wheel
$ newgrp wireshark
setgroups: Operation not permitted
setgid: Operation not permitted
--8<---------------cut here---------------end--------------->8---

I also added 'sg' since, in the shadow package, it's a symlink to 'newgrp'.

 gnu/system.scm | 2 ++
 1 file changed, 2 insertions(+)

Comments

宋文武 June 21, 2020, 3:36 a.m. UTC | #1 
Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.

Pushed, thank you!
Marius Bakke June 22, 2020, 9:14 p.m. UTC | #2 
Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.

LGTM.  Now I can remove this bit from my system config:

(setuid-programs (append (list #~(string-append #$shadow "/bin/newgrp"))
                         %setuid-programs)))
diff mbox series

Patch

diff --git a/gnu/system.scm b/gnu/system.scm
index 06bbc9e9c8..3e3d1927c2 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -932,7 +932,9 @@  use 'plain-file' instead~%")
   ;; Default set of setuid-root programs.
   (let ((shadow (@ (gnu packages admin) shadow)))
     (list (file-append shadow "/bin/passwd")
+          (file-append shadow "/bin/sg")
           (file-append shadow "/bin/su")
+          (file-append shadow "/bin/newgrp")
           (file-append shadow "/bin/newuidmap")
           (file-append shadow "/bin/newgidmap")
           (file-append inetutils "/bin/ping")