mbox

[bug#41653,0/4] Add (guix git-authenticate) with tests

Message ID 20200601212957.3056-1-ludo@gnu.org
Headers show

Message

Ludovic Courtès June 1, 2020, 9:29 p.m. UTC 
Hello Guix!

This series moves code from ‘build-aux/git-authenticate.scm’ to a proper
module in preparation of integration with (guix channels), as discussed
at <https://issues.guix.gnu.org/22883>.

More importantly, it adds tests.  I hope those tests are readable and
I would welcome feedback on all this!

Ludo’.

Ludovic Courtès (4):
  Add (guix git-authenticate).
  git-authenticate: Don't hard-code "origin/" for keyring reference.
  git-authenticate: Raise proper SRFI-35 conditions.
  git-authenticate: Add tests.

 .dir-locals.el                 |   2 +
 Makefile.am                    |   9 +-
 build-aux/git-authenticate.scm | 203 +----------------------
 guix/git-authenticate.scm      | 282 ++++++++++++++++++++++++++++++++
 guix/tests/git.scm             |  26 +--
 guix/tests/gnupg.scm           |  72 +++++++++
 tests/ed25519bis.key           |  10 ++
 tests/ed25519bis.sec           |  10 ++
 tests/git-authenticate.scm     | 286 +++++++++++++++++++++++++++++++++
 9 files changed, 684 insertions(+), 216 deletions(-)
 create mode 100644 guix/git-authenticate.scm
 create mode 100644 guix/tests/gnupg.scm
 create mode 100644 tests/ed25519bis.key
 create mode 100644 tests/ed25519bis.sec
 create mode 100644 tests/git-authenticate.scm

Comments

Ludovic Courtès June 5, 2020, 9:13 p.m. UTC | #1 
Hi,

Ludovic Courtès <ludo@gnu.org> skribis:

>   Add (guix git-authenticate).
>   git-authenticate: Don't hard-code "origin/" for keyring reference.
>   git-authenticate: Raise proper SRFI-35 conditions.
>   git-authenticate: Add tests.

Pushed!

I still take feedback though, for instance about the tests, because I’d
rather have more eyeballs for this kind of code.

Ludo’.