From patchwork Sun May 31 20:42:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Legoll X-Patchwork-Id: 22479 X-Patchwork-Delegate: mail@cbaines.net Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E1B6527BBE1; Sun, 31 May 2020 21:44:18 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 34CCE27BBE3 for ; Sun, 31 May 2020 21:44:18 +0100 (BST) Received: from localhost ([::1]:51062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfUob-0006uG-O0 for patchwork@mira.cbaines.net; Sun, 31 May 2020 16:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfUoO-0006cX-AY for guix-patches@gnu.org; Sun, 31 May 2020 16:44:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfUoO-0000qT-0k for guix-patches@gnu.org; Sun, 31 May 2020 16:44:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfUoN-0007K8-VP for guix-patches@gnu.org; Sun, 31 May 2020 16:44:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40601] [PATCH 6/7] guix-install.sh: Fix variable uses in guix_get_bin_list(). Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 31 May 2020 20:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40601@debbugs.gnu.org Cc: Vincent Legoll Received: via spool by 40601-submit@debbugs.gnu.org id=B40601.159095783728091 (code B ref 40601); Sun, 31 May 2020 20:44:03 +0000 Received: (at 40601) by debbugs.gnu.org; 31 May 2020 20:43:57 +0000 Received: from localhost ([127.0.0.1]:33940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfUo3-0007In-Mx for submit@debbugs.gnu.org; Sun, 31 May 2020 16:43:57 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfUnt-0007HS-AY for 40601@debbugs.gnu.org; Sun, 31 May 2020 16:43:33 -0400 Received: by mail-wr1-f67.google.com with SMTP id x13so9483465wrv.4 for <40601@debbugs.gnu.org>; Sun, 31 May 2020 13:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FNGy2kJNz0Llgz+YOnMLJPjsIHRK/neaz0idapHB0GA=; b=owt16Bm4xZZf+A+OvIRPqaspPIY/K7AXseb7pSYTDxsxz/WoynNSphjbYkeo4FwuFk 1ynCKfSkE19AOJ0q28F29IcqEBhEPDager6tUIjZZr4ts8Ifo3tABk2RsHnSMtAgx0iI Qm0nhvR2QUr8x6yOs4d2XNWgrfu2chG01Mg8UodZhz3VCSMr6tDFUjJrYk9SDa+nw0dX SNS0p/GvugWcB307ENgfSPo3iUveepTZyZ68/cuWRLcugW/ybL7HMyNAYk2Eefsyaxte kc2IzSrvFxYZu4YPwAgQ3bVEwHAjsYOhqypZM8lrtUoC1kKqF5l49Vcc1HI/U/GmsOVs d2Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FNGy2kJNz0Llgz+YOnMLJPjsIHRK/neaz0idapHB0GA=; b=VeaS/nEzSBicoxUb77PC3HwpvGO5ha9MOV2H65SQecMMsj7Gk26Bb7zk7VtxzdyyDk B3/Y7FSdE6x+0cKZLmJY0CG7rrtXlZE/GUkrYqKSn/LdNNjGy9uxCrjcCkRUhzqV05HA ZaPa89IvkjBaKtLlfSeXg5hMj0jB4pQlgFtFdSlpG+R5jT9DH/SoMyNL8xT9jiQb0s77 T92egoPQ4HZD1AkqclOA1/4rKxpS3vbOaORVBXHIfDdZqcxBh0D/ZSQXDWlOrx6PHzs2 CVA972kPrIHgMmr3tXhBSULSe8CjTDXbbYd7cOT6HcQSH9nmPLJ5Du2ScRAuQ3kkw60j XfEA== X-Gm-Message-State: AOAM531Bio+RqldRaJviiTC/fS1KEozPKTsxrMMgWN4Yd46LBGOQQHE4 2etsWe5Z5N8e7B3cyXlFG6zGq1AC X-Google-Smtp-Source: ABdhPJym6jnROHFUb80UD4Yba3FcbjuJNaeXDOwIDiDUcP9kpjuhv2rHLeXNMNC2DKNhLAKlv7v6WA== X-Received: by 2002:adf:f8cc:: with SMTP id f12mr18395714wrq.418.1590957807590; Sun, 31 May 2020 13:43:27 -0700 (PDT) Received: from localhost.localdomain (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1]) by smtp.gmail.com with ESMTPSA id w10sm18728850wrp.16.2020.05.31.13.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2020 13:43:27 -0700 (PDT) From: Vincent Legoll Date: Sun, 31 May 2020 22:42:56 +0200 Message-Id: <20200531204257.18725-6-vincent.legoll@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200531204257.18725-1-vincent.legoll@gmail.com> References: <20200531204257.18725-1-vincent.legoll@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * etc/guix-install.sh (guix_get_bin_list)[BIN_VER]: Add missing curly-brackets, [latest_ver]: Likewise & add explicit array zero-indexing. --- etc/guix-install.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 0e6e6842a1..7d635c2c38 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -210,7 +210,7 @@ guix_get_bin_list() | sed -n -e 's/.*guix-binary-\([0-9.]*\)\..*.tar.xz.*/\1/p' \ | sort -Vu)") - latest_ver="$(echo "$bin_ver_ls" \ + latest_ver="$(echo "${bin_ver_ls[0]}" \ | grep -oP "([0-9]{1,2}\.){2}[0-9]{1,2}" \ | tail -n1)" @@ -224,7 +224,7 @@ guix_get_bin_list() fi # Use default to download according to the list and local ARCH_OS. - BIN_VER="$default_ver" + BIN_VER="${default_ver}" } guix_get_bin()