diff mbox series

[bug#41446,2/2] gnu: dconf: Enable tests.

Message ID 20200522082154.1376-2-brice@waegenei.re
State Accepted
Headers show
Series dconf: Enable tests. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/applying patch success View Laminar job

Commit Message

Brice Waegeneire May 22, 2020, 8:21 a.m. UTC 
* gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
---
 gnu/packages/gnome.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Marius Bakke May 23, 2020, 5:42 p.m. UTC | #1 
Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.

dconf has over 400 dependent packages, so this should wait for the next
'staging' branch.  Can you fork off the current branch and push a
'staging-next' so it does not get forgotten?

Otherwise LGTM.  The other patch can go directly on 'master'.

Thanks!
Brice Waegeneire May 23, 2020, 8:05 p.m. UTC | #2 
On 2020-05-23 17:42, Marius Bakke wrote:
> Brice Waegeneire <brice@waegenei.re> writes:
> 
>> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
> 
> dconf has over 400 dependent packages, so this should wait for the next
> 'staging' branch.  Can you fork off the current branch and push a
> 'staging-next' so it does not get forgotten?
> 
> Otherwise LGTM.  The other patch can go directly on 'master'.
> 
> Thanks!

Pushed the first patch on master as 
79d7b5277f803d474f8934b1680ce598c9c27e2d.
And the second on staging-next as 
27106f465382fc95f0f19e1cd3147cab5716a173.
diff mbox series

Patch

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e9d2965f70..803ac8fe5a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3432,9 +3432,7 @@  and RDP protocols.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (arguments
-     `(#:tests? #f ; To contact dbus it needs to load /var/lib/dbus/machine-id
-                   ; or /etc/machine-id.
-       #:glib-or-gtk? #t
+     `(#:glib-or-gtk? #t
        #:configure-flags '("-Denable-gtk-doc=true")))
     (home-page "https://developer.gnome.org/dconf/")
     (synopsis "Low-level GNOME configuration system")