| Message ID | 20200511185022.23667-1-brice@waegenei.re |
|---|---|
| Headers | show |
On Mon, May 11, 2020 at 08:50:22PM +0200, Brice Waegeneire wrote: > This patchset update the network-manager packages first to support > all trafic trough wireguard and second to fix most of the issue > and workaround found in their definition. Thanks a lot for these patches! Can you say if they are tested and what you tried? I think there are some Guix system tests that should exercise NetworkManager. Can you check if they still pass?
On 2020-05-11 20:05, Leo Famulari wrote: > On Mon, May 11, 2020 at 08:50:22PM +0200, Brice Waegeneire wrote: >> This patchset update the network-manager packages first to support >> all trafic trough wireguard and second to fix most of the issue >> and workaround found in their definition. > > Thanks a lot for these patches! > > Can you say if they are tested and what you tried? I'm using network-manager patched now on my system ATM, I don't use the applet nor the plugins tho. So any testing is welcome. > I think there are some Guix system tests that should exercise > NetworkManager. Can you check if they still pass? I can't find the test in question, can you give me a hint were they should be? Cheers, - Brice
On Tue, May 12, 2020 at 09:12:33PM +0000, Brice Waegeneire wrote: > On 2020-05-11 20:05, Leo Famulari wrote: > > I think there are some Guix system tests that should exercise > > NetworkManager. Can you check if they still pass? > > I can't find the test in question, can you give me a hint were they > should be? The system tests are found in 'gnu/tests'. I know that %desktop-services (from 'gnu/services/desktop.scm') uses NetworkManager, so I grepped in 'gnu/tests' for %desktop-services, and found that some of the system installation tests use %desktop-services. Specifically, I think that the system test 'gui-installed-desktop-os-encrypted' should exercise NetworkManager: `make check-system TESTS=gui-installed-desktop-os-encrypted` It's not a hard requirement to run these tests IMO, especially since you are already using these patches successfully, but it's at least helpful to say if you tried or not.
Hello Leo, On 2020-05-12 21:36, Leo Famulari wrote: > On Tue, May 12, 2020 at 09:12:33PM +0000, Brice Waegeneire wrote: >> On 2020-05-11 20:05, Leo Famulari wrote: >> > I think there are some Guix system tests that should exercise >> > NetworkManager. Can you check if they still pass? >> >> I can't find the test in question, can you give me a hint were they >> should be? > > The system tests are found in 'gnu/tests'. > > I know that %desktop-services (from 'gnu/services/desktop.scm') uses > NetworkManager, so I grepped in 'gnu/tests' for %desktop-services, and > found that some of the system installation tests use %desktop-services. > > Specifically, I think that the system test > 'gui-installed-desktop-os-encrypted' should exercise NetworkManager: > > `make check-system TESTS=gui-installed-desktop-os-encrypted` > > It's not a hard requirement to run these tests IMO, especially since > you > are already using these patches successfully, but it's at least helpful > to say if you tried or not. I tired running the test but even on master it fails, CI can't built it either. But trying to built it with my patches I manage to find 2 gnome packages that broke because of it: they were looking for libnma in network-manager-applet which isn't included with it anymore. There aren't any other packages directly depending on network-manager-applet so there shouldn't be any other breakage relating to this specific issue. sirmacik tested the patchset too and used the vpnc plugin fine but as me he is not a user of the applet. Should we wait for the test to be fixed, before going forward with this patchset? I'm sending the v2 shortly. Cheers, - Brice
Add 2 commits fixing gnome packages, remove the libnma licenses update and add
comments to the new flag for network-manager-vpnc.
Brice Waegeneire (15):
gnu: network-manager: Update to 1.24.0.
gnu: network-manager: Add iwd support.
gnu: network-manager: Switch to meson-build-system.
gnu: network-manager: Appease guix lint.
gnu: modem-manager: Update to 1.12.10.
gnu: libnma: Update to 1.8.28.
gnu: libnma: Update inputs.
gnu: libnma: Adjust indentation.
gnu: network-manager-openvpn: Update to 1.8.12.
gnu: network-manager-openconnect: Use libnma.
gnu: network-manager-vpnc: Use 'libnma'.
gnu: network-manager-applet: Update to 1.16.0.
gnu: network-manager-applet: Appease guix lint.
gnu: gnome-initial-setup: Use 'libnma'.
gnu: gnome-control-center: Use 'libnma'.
gnu/local.mk | 2 +-
gnu/packages/freedesktop.scm | 10 +-
gnu/packages/gnome.scm | 258 ++++++++++--------
...atch => network-manager-plugin-path.patch} | 0
4 files changed, 142 insertions(+), 128 deletions(-)
rename gnu/packages/patches/{nm-plugin-path.patch => network-manager-plugin-path.patch} (100%)
Jonathan Brielmaier wrote: > On 11.05.20 22:01, Leo Famulari wrote: >> On Mon, May 11, 2020 at 09:00:44PM +0200, Brice Waegeneire wrote: >>> + `(#:configure-flags '("--enable-absolute-paths" >>> "--localstatedir=/var" >>> + "--with-libnm-glib=no") >> >> Can you add a brief code comment explaining this configure flag? > > And maybe one line per configure option :) That snip is misleading, the package already had the two option on the same line. I'll leave it to the person pushing this to tweak that line or dot it myself if a v3 is needed.
On Fri, May 22, 2020 at 04:35:52PM +0000, Brice Waegeneire wrote: > I tired running the test but even on master it fails, CI can't built it > either. But trying to built it with my patches I manage to find 2 gnome > packages that broke because of it: they were looking for libnma in > network-manager-applet which isn't included with it anymore. There aren't > any other packages directly depending on network-manager-applet so there > shouldn't be any other breakage relating to this specific issue. Okay. > sirmacik tested the patchset too and used the vpnc plugin fine but as me > he is not a user of the applet. Should we wait for the test to be fixed, > before going forward with this patchset? We don't need to wait, since we got some good test results from you and sirmacik. It would be great to get the test working again but I don't think it should block these patches.
This patchset update the network-manager packages first to support all trafic trough wireguard and second to fix most of the issue and workaround found in their definition. It's dependent on https://issues.guix.info/issue/41192 which add the openresolv package. Brice Waegeneire (13): gnu: network-manager: Update to 1.24.0. gnu: network-manager: Add iwd support. gnu: network-manager: Switch to meson-build-system. gnu: network-manager: Appease guix lint. gnu: modem-manager: Update to 1.12.10. gnu: libnma: Update to 1.8.28. gnu: libnma: Update inputs and licenses. gnu: libnma: Adjust indentation. gnu: network-manager-openvpn: Update to 1.8.12. gnu: network-manager-openconnect: Use libnma. gnu: network-manager-vpnc: Use libnma. gnu: network-manager-applet: Update to 1.16.0. gnu: network-manager-applet: Appease guix lint. gnu/local.mk | 2 +- gnu/packages/freedesktop.scm | 10 +- gnu/packages/gnome.scm | 254 ++++++++++-------- ...atch => network-manager-plugin-path.patch} | 0 4 files changed, 139 insertions(+), 127 deletions(-) rename gnu/packages/patches/{nm-plugin-path.patch => network-manager-plugin-path.patch} (100%)