mbox

[bug#40677,V3,00/15] Jami patches.

Message ID 20200502011450.2676-1-tona_kosmicznego_smiecia@interia.pl
Headers show

Message

Jan Wielkiewicz May 2, 2020, 1:14 a.m. UTC 
*** BLURB HERE ***

Hello,
I hope my commit messages are good now.
I removed some unnecessary commits.

Jan Wielkiewicz (15):
  gnu: telephony.scm: Move Jami and its dependencies to jami.scm.
  gnu: jami: Fix downloading.
  gnu: jami.scm: Add and use a generalized procedure for applying
    patches to Jami dependencies.
  gnu: Add libnatpmp.
  gnu: libring: Add libnatpmp as an optional dependency.
  gnu: libupnp: Bump to 1.8.6
  gnu: Add ffmpeg-jami.
  gnu: libring: Use ffmpeg-jami instead of ffmpeg.
  gnu: restinio: Bump to 0.6.1.1.
  gnu: jami: Make gettext a native input.
  gnu: pjproject, pjproject-jami: Bump to 2.10, apply new SFL patches.
  gnu: jami: Bump to 20200401.1.6f090de.
  gnu: jami: Replace gnu-gettext with gettext-minimal, just like on
    master.
  gnu: pjproject-jami: Add the missing, linux-only "--enable-epoll"
    flag.
  gnu: opendht: Bump to 2.0.0.

 gnu/local.mk                |   2 +
 gnu/packages/jami.scm       | 599 ++++++++++++++++++++++++++++++++++++
 gnu/packages/networking.scm |  50 ++-
 gnu/packages/telephony.scm  | 297 +-----------------
 gnu/packages/upnp.scm       |  18 +-
 5 files changed, 662 insertions(+), 304 deletions(-)
 create mode 100644 gnu/packages/jami.scm

Comments

Jan Wielkiewicz May 2, 2020, 11:26 a.m. UTC | #1 
On Sat, 02 May 2020 11:52:18 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> Hello Jan,
> 
> Thanks for this v3, I pushed everything except for the ffmpeg patches.
> When trying Jami on Ubuntu, I have the following errors:
> 
> --8<---------------cut here---------------start------------->8---
> ** (jami-gnome:3720): WARNING **: 11:46:10.955: Error : dring is not
> available, make sure it is running Gtk-Message: 11:46:11.008: Failed
> to load module "canberra-gtk-module" Gtk-Message: 11:46:11.009:
> Failed to load module "canberra-gtk-module"
> 
> ** (jami-gnome:3720): WARNING **: 11:46:11.010: Error : dring is not
> available, make sure it is running
> 
> (jami-gnome:3720): Gtk-WARNING **: 11:46:11.012: Theme parsing error:
> <data>:1:273: not a number
> 
> ** (jami-gnome:3720): WARNING **: 11:46:11.116: dring has possibly
> crashed, or has been killed... will wait 2.5 seconds and try to
> reconnect
> 
> ** (jami-gnome:3720): WARNING **: 11:46:13.623: Error : dring is not
> available, make sure it is running
> 
> ** (jami-gnome:3720): WARNING **: 11:46:13.623: Error : dring is not
> available, make sure it is running
> 
> ** (jami-gnome:3720): WARNING **: 11:46:13.623: could not reconnect
> to the daemon --8<---------------cut
> here---------------end--------------->8---
> 
> The problem is the same with the jami-20191101.3.67671e7 revision. Do
> you know why?
> 
> Thanks,
> 
> Mathieu

To be honest, I don't know why this happens. I was too focused on
correcting the commit messages I forgot about testing. Let me test it
now.


Jan Wielkiewicz
Jan Wielkiewicz May 2, 2020, 2:58 p.m. UTC | #2 
On Sat, 02 May 2020 11:52:18 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> The problem is the same with the jami-20191101.3.67671e7 revision. Do
> you know why?
> 

Okay I know the cause - I forgot to replace one occurrence of
"SFL-patches" in ffmpeg-jami with "sfl-patches". Could you fix it for
me or should I send the corrected version?

It works after changing it.

Jan Wielkiewicz
Mathieu Othacehe May 3, 2020, 7:34 a.m. UTC | #3 
Hello,

> To be honest, I don't know why this happens. I was too focused on
> correcting the commit messages I forgot about testing. Let me test it
> now.

I think the problem is that when starting "jami-gnome", the "dring"
daemon is started by D-Bus. On a foreign distro, this cannot work. So I
tried to start dring manually[1] but I have the following error:

--8<---------------cut here---------------start------------->8---
/gnu/store/chb71qh7dprrdgn7d3g08d2pbii57v2v-libring-20200401.1.6f090de/lib/ring/dring -cdp
Jami Daemon 9.1.0, by Savoir-faire Linux 2004-2019
https://jami.net/
[Video support enabled]

[1588491116.175|28401|ringbufferpool.cpp:118  ] Ringbuffer created with id 'audiolayer_id'
[1588491116.411|28401|video_device.h    :129  ] Default video settings: 800x480, 30 FPS
[1588491116.529|28401|video_device.h    :129  ] Default video settings: 960x540, 30 FPS
[1588491116.532|28401|manager.cpp       :676  ] Not initialized
[1588491116.532|28401|manager.cpp       :676  ] Not initialized
09:31:56.533         os_core_unix.c !pjlib 2.10 for POSIX initialized
[1588491116.534|28401|manager.cpp       :738  ] Using PJSIP version 2.10 for x86_64-unknown-linux-gnu
[1588491116.534|28401|manager.cpp       :739  ] Using GnuTLS version 3.6.13
[1588491116.534|28401|manager.cpp       :740  ] Using OpenDHT version 2.0.0
[1588491116.535|28401|manager.cpp       :751  ] Configuration file path: /home/mathieu/.config/jami/dring.yml
[1588491116.537|28401|manager.cpp       :2738 ] invalid node; first invalid key: "preferences": Preferences node unserialize error: 
[1588491116.538|28401|manager.cpp       :452  ] Errors while parsing /home/mathieu/.config/jami/dring.yml
[1588491116.538|28401|manager.cpp       :777  ] Restoring last working configuration
[1588491116.540|28401|sipvoiplink.cpp   :550  ] Using SIP nameserver: 127.0.0.53
[1588491116.540|28401|siptransport.cpp  :188  ] SipTransportBroker@0x125c3d0
[1588491116.541|28401|sipvoiplink.cpp   :641  ] SIPVoIPLink@0x1297410
[1588491116.541|28407|sip_utils.cpp     :203  ] Registered thread 0x7f132bc5f4d0 (0x6EF1)
[1588491116.541|28401|manager.cpp       :2738 ] invalid node; first invalid key: "preferences": Preferences node unserialize error: 
[1588491116.541|28401|manager.cpp       :452  ] Errors while parsing /home/mathieu/.config/jami/dring.yml
[1588491116.542|28401|sipvoiplink.cpp   :646  ] ~SIPVoIPLink@0x1297410
[1588491116.542|28401|siptransport.cpp  :193  ] ~SipTransportBroker@0x125c3d0
[1588491116.542|28401|siptransport.cpp  :200  ] destroying SipTransportBroker@0x125c3d0
dring: ../src/pj/os_core_unix.c:1325: pj_mutex_unlock: Assertion `mutex->owner == pj_thread_this()' failed.
Aborted (core dumped)
--8<---------------cut here---------------end--------------->8---

Maybe we should fix it, wrapping jami binary, so that it also starts
this daemon?

WDYT?

Thanks,

Mathieu

[1]: https://git.jami.net/savoirfairelinux/ring-project/wikis/technical/Build-instructions
Jan Wielkiewicz May 3, 2020, 2:32 p.m. UTC | #4 
On Sun, 03 May 2020 09:34:50 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> Hello,
> 
> 
> I think the problem is that when starting "jami-gnome", the "dring"
> daemon is started by D-Bus. On a foreign distro, this cannot work. So
> I tried to start dring manually[1] but I have the following error:
> 
> --8<---------------cut here---------------start------------->8---
> /gnu/store/chb71qh7dprrdgn7d3g08d2pbii57v2v-libring-20200401.1.6f090de/lib/ring/dring
> -cdp Jami Daemon 9.1.0, by Savoir-faire Linux 2004-2019
> https://jami.net/
> [Video support enabled]
> 
> [1588491116.175|28401|ringbufferpool.cpp:118  ] Ringbuffer created
> with id 'audiolayer_id' [1588491116.411|28401|video_device.h    :129
> ] Default video settings: 800x480, 30 FPS
> [1588491116.529|28401|video_device.h    :129  ] Default video
> settings: 960x540, 30 FPS
> [1588491116.532|28401|manager.cpp       :676  ] Not initialized
> [1588491116.532|28401|manager.cpp       :676  ] Not initialized
> 09:31:56.533         os_core_unix.c !pjlib 2.10 for POSIX initialized
> [1588491116.534|28401|manager.cpp       :738  ] Using PJSIP version
> 2.10 for x86_64-unknown-linux-gnu
> [1588491116.534|28401|manager.cpp       :739  ] Using GnuTLS version
> 3.6.13 [1588491116.534|28401|manager.cpp       :740  ] Using OpenDHT
> version 2.0.0 [1588491116.535|28401|manager.cpp       :751  ]
> Configuration file path: /home/mathieu/.config/jami/dring.yml
> [1588491116.537|28401|manager.cpp       :2738 ] invalid node; first
> invalid key: "preferences": Preferences node unserialize error:
> [1588491116.538|28401|manager.cpp       :452  ] Errors while
> parsing /home/mathieu/.config/jami/dring.yml
> [1588491116.538|28401|manager.cpp       :777  ] Restoring last
> working configuration [1588491116.540|28401|sipvoiplink.cpp   :550  ]
> Using SIP nameserver: 127.0.0.53
> [1588491116.540|28401|siptransport.cpp  :188  ]
> SipTransportBroker@0x125c3d0
> [1588491116.541|28401|sipvoiplink.cpp   :641  ] SIPVoIPLink@0x1297410
> [1588491116.541|28407|sip_utils.cpp     :203  ] Registered thread
> 0x7f132bc5f4d0 (0x6EF1) [1588491116.541|28401|manager.cpp       :2738
> ] invalid node; first invalid key: "preferences": Preferences node
> unserialize error: [1588491116.541|28401|manager.cpp       :452  ]
> Errors while parsing /home/mathieu/.config/jami/dring.yml
> [1588491116.542|28401|sipvoiplink.cpp   :646  ]
> ~SIPVoIPLink@0x1297410 [1588491116.542|28401|siptransport.cpp  :193
> ] ~SipTransportBroker@0x125c3d0
> [1588491116.542|28401|siptransport.cpp  :200  ] destroying
> SipTransportBroker@0x125c3d0 dring: ../src/pj/os_core_unix.c:1325:
> pj_mutex_unlock: Assertion `mutex->owner == pj_thread_this()' failed.
> Aborted (core dumped) --8<---------------cut
> here---------------end--------------->8---

This error is strange. I get nothing like this on Devuan - Jami just
starts automatically as the system loads.

> Maybe we should fix it, wrapping jami binary, so that it also starts
> this daemon?

I can try. Is it something similar to what we already have in jami
package - sqlite wrapper or should I just add dbus to propagated inputs?

> WDYT?
> 
> Thanks,
> 
> Mathieu
> 
> [1]:
> https://git.jami.net/savoirfairelinux/ring-project/wikis/technical/Build-instructions