From patchwork Tue Apr 28 21:28:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marcin Karpezo X-Patchwork-Id: 21740 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A1BDD27BBE4; Wed, 29 Apr 2020 01:49:14 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) by mira.cbaines.net (Postfix) with ESMTP id 5848D27BBE1 for ; Wed, 29 Apr 2020 01:49:14 +0100 (BST) Received: from localhost ([::1]:33814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTauX-0005Xy-Up for patchwork@mira.cbaines.net; Tue, 28 Apr 2020 20:49:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49654) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTXrf-0007l7-6o for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTXre-0005Px-GJ for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTXre-0005Ps-2m for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTXrd-0005Vi-Vq for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40950] [PATCH] mcron, create /var/cron/tabs on activation Resent-From: Marcin Karpezo Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Apr 2020 21:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40950 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40950@debbugs.gnu.org Cc: Marcin Karpezo X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158810960821124 (code B ref -1); Tue, 28 Apr 2020 21:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Apr 2020 21:33:28 +0000 Received: from localhost ([127.0.0.1]:41788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTXr6-0005Ue-Ku for submit@debbugs.gnu.org; Tue, 28 Apr 2020 17:33:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:35312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTXr4-0005UW-FL for submit@debbugs.gnu.org; Tue, 28 Apr 2020 17:33:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49002) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTXqv-0007Nj-Mb for guix-patches@gnu.org; Tue, 28 Apr 2020 17:33:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTXoq-0001ia-H9 for guix-patches@gnu.org; Tue, 28 Apr 2020 17:33:17 -0400 Received: from mail.freearts.agency ([51.68.137.137]:36300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jTXop-0001cf-9A for guix-patches@gnu.org; Tue, 28 Apr 2020 17:31:08 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A88CF40FF0; Tue, 28 Apr 2020 23:30:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wioo.waw.pl; s=dkim; t=1588109454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PyEmBMdcXWyzTZDXGNhvx8OykghW8YSYiZ/sjb6rrC8=; b=jrbrqhaxCTPuFTGmY/fHozpR4dZ5rpt1qsRi6yuabO+AY9IOVySG6FhDgfvhtPXthHKbs+ SkDZjVQoO60cD6gi8y6FBR/8RcOVwbUsb3hI5oCfk53XDJpPnl2kDSAZtMFaMhx+tuDEN8 CjgrveXpcrQKo4IjeYIVua1M2I4tE24V20AmvNvLXWiqZSqnosGjQGnNqWuAXOJ2pW9oAz OBAGM9NO9J1ZzEMn/lWlpjplWNh47yfkdOilizBgEtR3hheaZdA7sJHiXxek3aIXrR5+jR Lm/+exjxCit0AllWi937sXYI2cYkLqfDE7P5gn+shoj0Y61PvG8jYXjeHaS3GQ== From: Marcin Karpezo Date: Tue, 28 Apr 2020 23:28:53 +0200 Message-Id: <20200428212852.19552-1-sirmacik@wioo.waw.pl> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Received-SPF: pass client-ip=51.68.137.137; envelope-from=sirmacik@wioo.waw.pl; helo=mail.freearts.agency X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/28 17:30:58 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-Mailman-Approved-At: Tue, 28 Apr 2020 20:49:06 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches --- Hi! With big rekado help I'm sending you a patch with at least partially fixes the issue of crontab -e reporting missing /var/cron/tabs directory. gnu/services/mcron.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) --- 2.26.2 diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm index d9627c6bd0..ca9a54a041 100644 --- a/gnu/services/mcron.scm +++ b/gnu/services/mcron.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Ludovic Courtès +;;; Copyright © 2020 Marcin Karpezo ;;; ;;; This file is part of GNU Guix. ;;; @@ -128,6 +129,12 @@ files." (actions (list (shepherd-schedule-action mcron files))))))))) +(define (mcron-service-activation config) + (with-imported-modules '((guix build utils)) + #~(begin + (use-modules (guix build utils)) + (mkdir-p "/var/cron/tabs")))) + (define mcron-service-type (service-type (name 'mcron) (description @@ -137,7 +144,10 @@ files." mcron-shepherd-services) (service-extension profile-service-type (compose list - mcron-configuration-mcron)))) + mcron-configuration-mcron)) + (service-extension activation-service-type + mcron-service-activation))) + (compose concatenate) (extend (lambda (config jobs) (mcron-configuration