diff mbox series

[bug#40938] doc: Lower 'Kernel Module Loader Service' one level.

Message ID 20200428142141.13636-1-brice@waegenei.re
State Accepted
Headers show
Series [bug#40938] doc: Lower 'Kernel Module Loader Service' one level. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Brice Waegeneire April 28, 2020, 2:21 p.m. UTC 
* doc/guix.texi (Kernel Module Loader Service): Move it from under
'Early OOM Service' to 'Services'.
---

I made a typo when first submiting the module.

 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mathieu Othacehe May 1, 2020, 11:41 a.m. UTC | #1 
Hello Brice,

>  @cindex modprobe
>  @cindex kernel module loader
> -@subsubsection Kernel Module Loader Service
> +@subsection Kernel Module Loader Service

I have the following warning when applying this patch:

--8<---------------cut here---------------start------------->8---
  MAKEINFO doc/guix.info
./doc/guix.texi:25493: warning: node `Miscellaneous Services' is next for `Linux Services' in menu but not in sectioning
./doc/guix.texi:25595: warning: node `Linux Services' is prev for `Miscellaneous Services' in menu but not in sectioning
--8<---------------cut here---------------end--------------->8---

Do you know why?

Thanks,

Mathieu
Brice Waegeneire May 1, 2020, 2:27 p.m. UTC | #2 
Hello Mathieu,

On 2020-05-01 11:41, Mathieu Othacehe wrote:
> I have the following warning when applying this patch:
> 
> --8<---------------cut here---------------start------------->8---
>   MAKEINFO doc/guix.info
> ./doc/guix.texi:25493: warning: node `Miscellaneous Services' is next
> for `Linux Services' in menu but not in sectioning
> ./doc/guix.texi:25595: warning: node `Linux Services' is prev for
> `Miscellaneous Services' in menu but not in sectioning
> --8<---------------cut here---------------end--------------->8---
> 
> Do you know why?

It wasn't correctly patched, it turns out the whole 'Linux Services'
section wasn't properly organized compared to the other services
sections. I've found a similar issue with 'Dictionary Service',
so I added a patch for it in this series.

- Brice
Mathieu Othacehe May 1, 2020, 2:42 p.m. UTC | #3 
> It wasn't correctly patched, it turns out the whole 'Linux Services'
> section wasn't properly organized compared to the other services
> sections. I've found a similar issue with 'Dictionary Service',
> so I added a patch for it in this series.

Ok, this look fine! I pushed your v2.

Thanks,

Mathieu
diff mbox series

Patch

diff --git a/doc/guix.texi b/doc/guix.texi
index cea4eeb984..89699e6ca5 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25679,7 +25679,7 @@  notifications.
 
 @cindex modprobe
 @cindex kernel module loader
-@subsubsection Kernel Module Loader Service
+@subsection Kernel Module Loader Service
 
 The kernel module loader service allows one to load loadable kernel
 modules at boot.  This is especially useful for modules that don't