Message ID | 20200427135550.20640-1-brice@waegenei.re |
---|---|
State | Accepted |
Headers | show |
Series | [bug#40902] gnu: Add edid-decode. | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | success | View Laminar job |
Hello Brice, You can add your copyright. > +(define-public edid-decode > + (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ; 2020-04-22 > + (revision "1")) > + (package > + (name "edid-decode") > + (version (git-version "0.0.0" revision commit)) The indentation of the block seems wrong. > + (source > + (origin > + (method git-fetch) > + (file-name (git-file-name name version)) > + (uri (git-reference > + (url "git://linuxtv.org/edid-decode.git") > + (commit commit))) > + (sha256 > + (base32 "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; No test suite > + #:make-flags > + (list (string-append "DESTDIR=" (assoc-ref %outputs "out")) > + "bindir=/bin" "mandir=/share/man") > + #:phases > + (modify-phases %standard-phases > + (delete 'configure)))) When cross-compiling, a native binary is produced. This is because CXX is set to 'g++' I guess. You need to do something similar to what is done in the 'maradns' package. Thanks, Mathieu
Hello Mathieu, Thank you for taking the time to review this patch. On 2020-04-28 07:46, Mathieu Othacehe wrote: > Hello Brice, > > You can add your copyright. I already added it in #40607[0], an unmerged patch adding usbguard. >> +(define-public edid-decode >> + (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ; >> 2020-04-22 >> + (revision "1")) >> + (package >> + (name "edid-decode") >> + (version (git-version "0.0.0" revision commit)) > > The indentation of the block seems wrong. You are correct, “guix lint” didn't mentioned it though. Fixed in v2. >> + (source >> + (origin >> + (method git-fetch) >> + (file-name (git-file-name name version)) >> + (uri (git-reference >> + (url "git://linuxtv.org/edid-decode.git") >> + (commit commit))) >> + (sha256 >> + (base32 >> "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah")))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:tests? #f ; No test suite >> + #:make-flags >> + (list (string-append "DESTDIR=" (assoc-ref %outputs "out")) >> + "bindir=/bin" "mandir=/share/man") >> + #:phases >> + (modify-phases %standard-phases >> + (delete 'configure)))) > > When cross-compiling, a native binary is produced. This is because CXX > is set to 'g++' I guess. You need to do something similar to what is > done in the 'maradns' package. I never thought of testing that, I should start doing it. Fixed in v2. [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40607#28 - Brice
diff --git a/gnu/packages/hardware.scm b/gnu/packages/hardware.scm index 189c73ee3c..3284733095 100644 --- a/gnu/packages/hardware.scm +++ b/gnu/packages/hardware.scm @@ -89,6 +89,36 @@ calibrated, and restored when the calibration is applied.") (license (list license:bsd-3 ; FindDDCUtil.cmake license:gpl2+)))) ; everything else +(define-public edid-decode + (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ; 2020-04-22 + (revision "1")) + (package + (name "edid-decode") + (version (git-version "0.0.0" revision commit)) + (source + (origin + (method git-fetch) + (file-name (git-file-name name version)) + (uri (git-reference + (url "git://linuxtv.org/edid-decode.git") + (commit commit))) + (sha256 + (base32 "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; No test suite + #:make-flags + (list (string-append "DESTDIR=" (assoc-ref %outputs "out")) + "bindir=/bin" "mandir=/share/man") + #:phases + (modify-phases %standard-phases + (delete 'configure)))) + (home-page "https://git.linuxtv.org/edid-decode.git/") + (synopsis "Decode @dfn{EDID} data in human-readable format") + (description "edid-decode decodes @dfn{EDID} monitor description data in +human-readable format and check if it conforms to the standards.") + (license license:expat)))) + ;; Distinct from memtest86, which is obsolete. (define-public memtest86+ (package