| Message ID | 20200426185823.5652-1-mail@cbaines.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#40876,core-updates] gnu: libgc/static-libs: Mark it as hidden. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | View Laminar job |
Christopher Baines <mail@cbaines.net> writes: > * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t. > --- > gnu/packages/bdw-gc.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm > index 112a161f94..50e4951dc1 100644 > --- a/gnu/packages/bdw-gc.scm > +++ b/gnu/packages/bdw-gc.scm > @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.") > libgc > (arguments (substitute-keyword-arguments (package-arguments libgc) > ((#:configure-flags flags ''()) > - `(cons "--enable-static" ,flags)))))) > + `(cons "--enable-static" ,flags)))) > + (properties '((hidden? . #t))))) > > (define-public libgc-7 > (package Forgot to include you Marius when I sent this patch. Does this seem sensible? Otherwise you get this libgc variant when you use Guix on the command line, and commands like guix lint complain. ./pre-inst-env guix lint libgc guix lint: warning: ambiguous package specification `libgc' guix lint: warning: choosing libgc@8.0.4 from gnu/packages/bdw-gc.scm:90:2 I hope that setting the properties doesn't involve rebuilding anything. Thanks, Chris
Christopher Baines <mail@cbaines.net> writes: > * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t. > --- > gnu/packages/bdw-gc.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm > index 112a161f94..50e4951dc1 100644 > --- a/gnu/packages/bdw-gc.scm > +++ b/gnu/packages/bdw-gc.scm > @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.") > libgc > (arguments (substitute-keyword-arguments (package-arguments libgc) > ((#:configure-flags flags ''()) > - `(cons "--enable-static" ,flags)))))) > + `(cons "--enable-static" ,flags)))) > + (properties '((hidden? . #t))))) LGTM, thanks! Properties are only used by the Guix 'front-end' and not part of the derivation.
Marius Bakke <mbakke@fastmail.com> writes: > Christopher Baines <mail@cbaines.net> writes: > >> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t. >> --- >> gnu/packages/bdw-gc.scm | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm >> index 112a161f94..50e4951dc1 100644 >> --- a/gnu/packages/bdw-gc.scm >> +++ b/gnu/packages/bdw-gc.scm >> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.") >> libgc >> (arguments (substitute-keyword-arguments (package-arguments libgc) >> ((#:configure-flags flags ''()) >> - `(cons "--enable-static" ,flags)))))) >> + `(cons "--enable-static" ,flags)))) >> + (properties '((hidden? . #t))))) > > LGTM, thanks! Properties are only used by the Guix 'front-end' and not > part of the derivation. Great, I've pushed this as 709ca6c9824e4bbb0d81959b885248294fb062ae now.
diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm index 112a161f94..50e4951dc1 100644 --- a/gnu/packages/bdw-gc.scm +++ b/gnu/packages/bdw-gc.scm @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.") libgc (arguments (substitute-keyword-arguments (package-arguments libgc) ((#:configure-flags flags ''()) - `(cons "--enable-static" ,flags)))))) + `(cons "--enable-static" ,flags)))) + (properties '((hidden? . #t))))) (define-public libgc-7 (package