From patchwork Sun Apr 26 09:53:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghav Gururajan X-Patchwork-Id: 21476 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2A7B127BBE1; Sun, 26 Apr 2020 10:54:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id A1D6927BBEA for ; Sun, 26 Apr 2020 10:54:08 +0100 (BST) Received: from localhost ([::1]:56078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSdzE-00074Q-78 for patchwork@mira.cbaines.net; Sun, 26 Apr 2020 05:54:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43650) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSdz9-00074A-7T for guix-patches@gnu.org; Sun, 26 Apr 2020 05:54:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSdz8-0000mS-AV for guix-patches@gnu.org; Sun, 26 Apr 2020 05:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSdz7-0000l6-Sy for guix-patches@gnu.org; Sun, 26 Apr 2020 05:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSdz7-0005ks-Ra for guix-patches@gnu.org; Sun, 26 Apr 2020 05:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40862] gnu: Add xarchiver. (v2) Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Apr 2020 09:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40862 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 40862@debbugs.gnu.org Received: via spool by 40862-submit@debbugs.gnu.org id=B40862.158789480822076 (code B ref 40862); Sun, 26 Apr 2020 09:54:01 +0000 Received: (at 40862) by debbugs.gnu.org; 26 Apr 2020 09:53:28 +0000 Received: from localhost ([127.0.0.1]:60883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSdyZ-0005k0-UX for submit@debbugs.gnu.org; Sun, 26 Apr 2020 05:53:28 -0400 Received: from knopi.disroot.org ([178.21.23.139]:38938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSdyX-0005jr-If for 40862@debbugs.gnu.org; Sun, 26 Apr 2020 05:53:26 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 04ADB24B27; Sun, 26 Apr 2020 11:53:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FHLMMuRvFiT1; Sun, 26 Apr 2020 11:53:22 +0200 (CEST) Date: Sun, 26 Apr 2020 05:53:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1587894802; bh=1X4jkouV9djGv3+cuk4ezhYWV6GCCrT4C+gllTtWr6A=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=RnTE5PzBhnQux86o2KMCkdB1wLmfgPfKWD3fXkE9aaKqyxFpPeH2d0pw669fIW7SW WEAcwBHtT6VJ/lGMBflkdRsScPo42NWMW8QeYh1lj7mVe7iV+l1ggSkZd93lIGuask eX2YzUDH9T4YAZEyw9NpwvdYxd+bjJfPVuPx6Hxi4H0FXGdoMjQHDS0HiU8UIv9QTt Yp7HUJOzZTH8cO2W+6AZ3p8EtH6KFkd1YHgSDZy4F9tI2Q1tXnNi+b6iDPzodKPQZk JZ08elC21lUVUH2U1B20SZWOCmGWlj334eZiylmU0YtbJuJBSfFcKGVQZU4JLlsSk0 5Lv0xaIuL0Z8w== From: Raghav Gururajan Message-ID: <20200426055305.4bb9fc0f.raghavgururajan@disroot.org> In-Reply-To: <87ftcqfvoy.fsf@gmail.com> References: <20200426045129.31f36e15.raghavgururajan@disroot.org> <87ftcqfvoy.fsf@gmail.com> Mime-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Mathieu! > Thanks for this patch. When running 'guix lint' on this patch, I have > the following warnings: > > --8<---------------cut here---------------start------------->8--- > /home/mathieu/guix-master/gnu/packages/compression.scm:87:5: > xarchiver@0.5.4.14: the source file name should contain the package name > /home/mathieu/guix-master/gnu/packages/compression.scm:87:5: > xarchiver@0.5.4.14: the source URI should not be an autogenerated tarball > fetching CVE database for 2020...... fetching CVE database for 2019... > fetching CVE database for 2018... fetching CVE database for 2017... > /home/mathieu/guix-master/gnu/packages/compression.scm:85:13: > xarchiver@0.5.4.14: can be upgraded to 0.5b2 --8<---------------cut > here---------------end--------------->8--- > > > > > +(define-public xarchiver > > + (package > > + (name "xarchiver") > > + (version "0.5.4.14") > > + (source > > + (origin > > + (method url-fetch) > > + (uri > > + (string-append "https://github.com/ib/" name "/archive/" > > + version ".tar.gz")) > > You should use "git-fetch" method for github repositories (see linter > warning above). > > > + (list > > + "--disable-plugin"))) ; Not required > > Why is it not required? > > > + (synopsis "Graphical Front-end for Archive Operations") > > No camel case notation. > > > + (description "Xarchiver is the ultimate solution for handling > > archives. It +is a desktop-environment independent archiver front end.") > > "Ultimate" is maybe exaggerated! Also you could elaborate a bit on the > functionalities of this tool. Please find the revised patch attached with this email. Regards, RG. From 23e7dc347108c75f92d5bafd17b39cba47eed486 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sun, 26 Apr 2020 05:50:47 -0400 Subject: [PATCH] gnu: Add xarchiver. * gnu/packages/compression (xarchiver): New variable. --- gnu/packages/compression.scm | 38 ++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index e9ef302bcd..7333810c73 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -50,6 +50,7 @@ #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix build-system cmake) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system python) #:use-module (guix build-system trivial) @@ -63,6 +64,10 @@ #:use-module (gnu packages curl) #:use-module (gnu packages documentation) #:use-module (gnu packages file) + #:use-module (gnu packages gettext) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) #:use-module (gnu packages maths) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) @@ -70,9 +75,42 @@ #:use-module (gnu packages qt) #:use-module (gnu packages tls) #:use-module (gnu packages valgrind) + #:use-module (gnu packages xml) #:use-module (ice-9 match) #:use-module ((srfi srfi-1) #:select (last))) +(define-public xarchiver + (package + (name "xarchiver") + (version "0.5.4.14") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/ib/xarchiver.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1iklwgykgymrwcc5p1cdbh91v0ih1m58s3w9ndl5kyd44bwlb7px")))) + (build-system glib-or-gtk-build-system) + (native-inputs + `(("gettext" ,gettext-minimal) + ("intltool" ,intltool) + ("libxslt" ,libxslt) + ("pkg-config" ,pkg-config))) + (inputs + `(("adwaita-icon-theme" ,adwaita-icon-theme) ; Hard-coded theme + ("gtk+" ,gtk+))) + (synopsis "Graphical front-end for archive operations") + (description "Xarchiver is a front-end to various command line archiving +tools. It uses GTK+ tool-kit and is designed to be desktop-environment +independent. Supported formats are 7z, ARJ, bzip2, gzip, LHA, lzma, lzop, RAR, +RPM, DEB, tar, and ZIP. It cannot perform functions for archives, whose +archiver is not installed.") + (home-page "https://github.com/ib/xarchiver") + (license license:gpl2+))) + (define-public zlib (package (name "zlib") -- 2.26.2