diff mbox series

[bug#40785] guix: edit: Make nano the default editor.

Message ID 20200422205850.518dbe3e.raghavgururajan@disroot.org
State Accepted
Headers show
Series [bug#40785] guix: edit: Make nano the default editor. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

Raghav Gururajan April 23, 2020, 12:58 a.m. UTC

Comments

Ludovic Courtès April 27, 2020, 9:28 p.m. UTC | #1 
Hi,

Raghav Gururajan <raghavgururajan@disroot.org> skribis:

>>From c0770e600823315dddb6a6c273e461c98195622f Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Wed, 22 Apr 2020 20:55:40 -0400
> Subject: [PATCH] guix: edit: Make nano the default editor.
>
> * guix/scripts/edit.scm: Make nano the default editor.
>
> Nano is sensible default, as it is installed by base system.
> For development, user can set custom value for $EDITOR.

Applied, thanks!

Ludo’.
diff mbox series

Patch

From c0770e600823315dddb6a6c273e461c98195622f Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Wed, 22 Apr 2020 20:55:40 -0400
Subject: [PATCH] guix: edit: Make nano the default editor.

* guix/scripts/edit.scm: Make nano the default editor.

Nano is sensible default, as it is installed by base system.
For development, user can set custom value for $EDITOR.
---
 guix/scripts/edit.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/guix/scripts/edit.scm b/guix/scripts/edit.scm
index a6fd1d2751..43f3011869 100644
--- a/guix/scripts/edit.scm
+++ b/guix/scripts/edit.scm
@@ -56,10 +56,9 @@  Start $VISUAL or $EDITOR to edit the definitions of PACKAGE...\n"))
   (show-bug-report-information))
 
 (define %editor
-  ;; XXX: It would be better to default to something more likely to be
-  ;; pre-installed on an average GNU system.  Since Nano is not suited for
-  ;; editing Scheme, Emacs is used instead.
-  (make-parameter (or (getenv "VISUAL") (getenv "EDITOR") "emacs")))
+  ;; Nano is sensible default, as it is installed by base system.
+  ;; For development, user can set custom value for $EDITOR.
+  (make-parameter (or (getenv "VISUAL") (getenv "EDITOR") "nano")))
 
 (define (search-path* path file)
   "Like 'search-path' but exit if FILE is not found."
-- 
2.26.1