diff mbox series

[bug#40479] : Add fdroidcl.

Message ID 20200420091653.GE7353@E5400
State Accepted
Headers show
Series [bug#40479] : Add fdroidcl. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Efraim Flashner April 20, 2020, 9:16 a.m. UTC 
I made a couple of changes to the patch. It now downloads the source
using git-fetch and I updated the inputs a bit.

For the tests, I'm afraid you're going to need to package the
missing package.

Comments

Ludovic Courtès Sept. 9, 2020, 9:21 p.m. UTC | #1 
Hi,

Efraim Flashner <efraim@flashner.co.il> skribis:

> I made a couple of changes to the patch. It now downloads the source
> using git-fetch and I updated the inputs a bit.
>
> For the tests, I'm afraid you're going to need to package the
> missing package.

[...]

> From efd8708885f451b34cbb712ef6a7d97e8ea598c4 Mon Sep 17 00:00:00 2001
> From: Sergey Trofimov <sarg@sarg.org.ru>
> Date: Tue, 7 Apr 2020 06:57:13 +0200
> Subject: [PATCH] gnu: Add fdroidcl.
>
> * gnu/packages/android (fdroidcl): New variable.

[...]

> +    (native-inputs
> +     `(;; used in tests
> +       ;; ("go-github-com-rogpeppe-go-internal-testscript"
> +       ;;  ,go-github-com-rogpeppe-go-internal-testscript)

Perhaps make the comment a TODO and push?

Thanks,
Ludo’.
Efraim Flashner Sept. 10, 2020, 7:59 a.m. UTC | #2 
On Wed, Sep 09, 2020 at 11:21:27PM +0200, Ludovic Courtès wrote:
> Hi,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > I made a couple of changes to the patch. It now downloads the source
> > using git-fetch and I updated the inputs a bit.
> >
> > For the tests, I'm afraid you're going to need to package the
> > missing package.
> 
> [...]
> 
> > From efd8708885f451b34cbb712ef6a7d97e8ea598c4 Mon Sep 17 00:00:00 2001
> > From: Sergey Trofimov <sarg@sarg.org.ru>
> > Date: Tue, 7 Apr 2020 06:57:13 +0200
> > Subject: [PATCH] gnu: Add fdroidcl.
> >
> > * gnu/packages/android (fdroidcl): New variable.
> 
> [...]
> 
> > +    (native-inputs
> > +     `(;; used in tests
> > +       ;; ("go-github-com-rogpeppe-go-internal-testscript"
> > +       ;;  ,go-github-com-rogpeppe-go-internal-testscript)
> 
> Perhaps make the comment a TODO and push?
> 
> Thanks,
> Ludo’.

Works for me.
diff mbox series

Patch

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 17f5f41fcb..a32d6c570c 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -10,6 +10,7 @@ 
 ;;; Copyright © 2019 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2019 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2020 Sergey Trofimov <sarg@sarg.org.ru>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@ 
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system android-ndk)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module ((guix licenses) #:prefix license:)
@@ -41,6 +43,7 @@ 
   #:use-module (gnu packages docker)
   #:use-module (gnu packages gcc)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages java)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pcre)
@@ -946,6 +949,39 @@  publishing, or to assist in creating, testing and submitting metadata to the
 main repository.")
     (license license:agpl3+)))
 
+(define-public fdroidcl
+  (package
+    (name "fdroidcl")
+    (version "0.5.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/mvdan/fdroidcl")
+                     (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "1rxcdyy2j34z0ql9d62w7ivsch9xihjnpb1z9kgy9q46vl8zhhy0"))))
+    (build-system go-build-system)
+    (arguments
+     `(#:import-path "mvdan.cc/fdroidcl"
+       #:tests? #f  ; TODO.
+       #:install-source? #f))
+    (inputs
+     `(("go-github-com-kr-pretty"
+        ,go-github-com-kr-pretty)))
+    (native-inputs
+     `(;; used in tests
+       ;; ("go-github-com-rogpeppe-go-internal-testscript"
+       ;;  ,go-github-com-rogpeppe-go-internal-testscript)
+       ))
+    (synopsis "F-Droid desktop client")
+    (description
+     "While the Android client integrates with the system with regular update
+checks and notifications, this is a simple command line client that talks to
+connected devices via ADB.")
+    (home-page "https://github.com/mvdan/fdroidcl")
+    (license license:bsd-3)))
+
 (define-public enjarify
   (package
     (name "enjarify")