diff mbox series

[bug#40668] installer: Fix backtrace display.

Message ID 20200416173354.11807-1-m.othacehe@gmail.com
State Accepted
Headers show
Series [bug#40668] installer: Fix backtrace display. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Mathieu Othacehe April 16, 2020, 5:33 p.m. UTC 
The 'syslog' macro cannot be resolved in the pre-unwind-handler
context. Failed to resolve 'syslog' in this context resulted in the swallowing
of all installation errors.

Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.

* gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
in the pre-unwind-handler.
---

Hello,

Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
this means that every error happening in the 1.1.0 release will result in an
installer restart, without any error information reporting. 

Thanks,

Mathieu

 gnu/installer.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Ludovic Courtès April 17, 2020, 9:07 p.m. UTC | #1 
Hello,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> The 'syslog' macro cannot be resolved in the pre-unwind-handler
> context. Failed to resolve 'syslog' in this context resulted in the swallowing
> of all installation errors.
>
> Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.
>
> * gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
> in the pre-unwind-handler.

[...]

> Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
> this means that every error happening in the 1.1.0 release will result in an
> installer restart, without any error information reporting. 

Oh, that’s terrible.  :-/  Sorry about that.

> -                  (syslog "crashing due to uncaught exception: ~s ~s~%"
> -                          key args)
> +                  ((@@ (gnu installer utils) syslog)
> +                   "crashing due to uncaught exception: ~s ~s~%"
> +                   key args)

Please add (gnu installer utils) to the list of use-modules.
‘@@’ should only be used in extreme situations.

Thanks,
Ludo’.
Mathieu Othacehe April 18, 2020, 3:46 p.m. UTC | #2 
Hey,

> Please add (gnu installer utils) to the list of use-modules.
> ‘@@’ should only be used in extreme situations.

Fixed and pushed!

Thanks,

Mathieu
diff mbox series

Patch

diff --git a/gnu/installer.scm b/gnu/installer.scm
index 1051ee1e5f..eba8a7d428 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -436,8 +436,9 @@  selected keymap."
                      #f)))
                 (const #f)
                 (lambda (key . args)
-                  (syslog "crashing due to uncaught exception: ~s ~s~%"
-                          key args)
+                  ((@@ (gnu installer utils) syslog)
+                   "crashing due to uncaught exception: ~s ~s~%"
+                   key args)
                   (let ((error-file "/tmp/last-installer-error"))
                     (call-with-output-file error-file
                       (lambda (port)