From patchwork Fri Apr 3 12:58:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "pelzflorian (Florian Pelz)" X-Patchwork-Id: 21071 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6B62627BBE1; Fri, 3 Apr 2020 13:59:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id C9ED927BBE4 for ; Fri, 3 Apr 2020 13:59:12 +0100 (BST) Received: from localhost ([::1]:55068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKLui-0000fS-8R for patchwork@mira.cbaines.net; Fri, 03 Apr 2020 08:59:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57187) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKLua-0000fG-BY for guix-patches@gnu.org; Fri, 03 Apr 2020 08:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKLuY-0000Z8-4Y for guix-patches@gnu.org; Fri, 03 Apr 2020 08:59:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKLuY-0000YR-1A for guix-patches@gnu.org; Fri, 03 Apr 2020 08:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKLuX-0006y7-VT for guix-patches@gnu.org; Fri, 03 Apr 2020 08:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40274] [PATCH v5] gnu: Add kernel-module-loader-service. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Apr 2020 12:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40274 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 40274@debbugs.gnu.org, ludo@gnu.org, Brice Waegeneire Received: via spool by 40274-submit@debbugs.gnu.org id=B40274.158591872526735 (code B ref 40274); Fri, 03 Apr 2020 12:59:01 +0000 Received: (at 40274) by debbugs.gnu.org; 3 Apr 2020 12:58:45 +0000 Received: from localhost ([127.0.0.1]:41363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKLuH-0006x9-2t for submit@debbugs.gnu.org; Fri, 03 Apr 2020 08:58:45 -0400 Received: from pelzflorian.de ([5.45.111.108]:47196 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKLuE-0006ws-9H for 40274@debbugs.gnu.org; Fri, 03 Apr 2020 08:58:44 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 06D42360566; Fri, 3 Apr 2020 14:58:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1585918721; bh=9xXnT+RKlWXlTsB+NBU7pG7IgzTUZe+mRtF0dlr6UFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YoAOrqcMxg0r0S4xAfRAWyiQaRrIpPAvhW85IYrqYLb4FiwCz9cMBej7IZBHIdZo9 ajCn3upQzbetjaOPHZK4Y8kqikOmJ3NHsK4ifvbcvxaW7uNzGXETHkdx3raL0VNOM6 E9NseodDsHdYmdIwfsfIdL050lx+nX2RL5GhnI2I= Date: Fri, 3 Apr 2020 14:58:39 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20200403125839.bci5jduvxrhvw673@pelzflorian.localdomain> References: <20200328135908.2540-1-brice@waegenei.re> <20200402123712.338-1-brice@waegenei.re> <20200402155640.121e4879@scratchpost.org> <2b32956fc10fd3012388722e1b00ce21@waegenei.re> <20200403122044.2f9e2552@scratchpost.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403122044.2f9e2552@scratchpost.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On Fri, Apr 03, 2020 at 12:20:44PM +0200, Danny Milosavljevic wrote: > On Thu, 02 Apr 2020 17:13:05 +0000 Brice Waegeneire wrote: > > *could* be useful, to some, to pass arguments to modprobe since it is > > present in its API; > Definitely could be useful. The question is whether the complexity justifies it > and whether it can be reliable. I need modprobe arguments in some way via some service to pass to the uvesafb module to make graphics and kmscon work on machines without Kernel Mode Setting (see attachment), but the (string-append …) is not executed as a procedure, it seems. Apr 3 14:54:45 localhost vmunix: [ 9.860831] shepherd[1]: Service user-homes has been started. Apr 3 14:54:45 localhost vmunix: [ 9.880505] shepherd[1]: '/gnu/store/d064bv2b1hrb07j2zj78i608db7qldx9-kmod-26/bin/modprobe -- uvesafb (string-append v86d= /gnu/store/0m780n5q4cr7rqmjn5zzd6adr3042f97-v86d-0.1.10 /sbin/v86d) mode_option=1024x768' exited with status 127; output follows: Apr 3 14:54:45 localhost vmunix: [ 9.881867] shepherd[1]: Apr 3 14:54:45 localhost vmunix: [ 9.883595] shepherd[1]: Service kernel-module-loader could not be started. Regards, Florian diff --git a/gnu/system/install.scm b/gnu/system/install.scm index c15c2c7814..7327efe195 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -26,11 +26,13 @@ #:use-module (gnu bootloader u-boot) #:use-module (guix gexp) #:use-module (guix store) + #:use-module (guix utils) #:use-module (guix monads) #:use-module ((guix packages) #:select (package-version)) #:use-module ((guix store) #:select (%store-prefix)) #:use-module (gnu installer) #:use-module (gnu services dbus) + #:use-module (gnu services linux) #:use-module (gnu services networking) #:use-module (gnu services shepherd) #:use-module (gnu services ssh) @@ -50,6 +52,7 @@ #:use-module (gnu packages texinfo) #:use-module (gnu packages compression) #:use-module (gnu packages nvi) + #:use-module (gnu packages xorg) #:use-module (ice-9 match) #:use-module (srfi srfi-26) #:export (installation-os @@ -304,7 +307,8 @@ Access documentation at any time by pressing Alt-F2.\x1b[0m (define bare-bones-os (load "examples/bare-bones.tmpl")) - (list (service virtual-terminal-service-type) + (cons* + (service virtual-terminal-service-type) (service kmscon-service-type (kmscon-configuration @@ -408,7 +412,14 @@ Access documentation at any time by pressing Alt-F2.\x1b[0m (list bare-bones-os glibc-utf8-locales texinfo - (canonical-package guile-2.2)))))) + (canonical-package guile-2.2))) + (if (member (%current-system) '("x86_64-linux" "i686-linux")) + ;; Load uvesafb to show installer when no KMS is available. + `(,(kernel-module-loader-service + (list (list "uvesafb" + #~(string-append "v86d=" #$v86d "/sbin/v86d") + "mode_option=1024x768")))) + '())))) (define %issue ;; Greeting.