From patchwork Wed Apr 1 19:34:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "pelzflorian (Florian Pelz)" X-Patchwork-Id: 21042 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 350E727BBE1; Wed, 1 Apr 2020 20:36:28 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id C707B27BBE4 for ; Wed, 1 Apr 2020 20:36:27 +0100 (BST) Received: from localhost ([::1]:36508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJjA3-0001kO-6i for patchwork@mira.cbaines.net; Wed, 01 Apr 2020 15:36:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36120) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJj9j-0001kB-Hi for guix-patches@gnu.org; Wed, 01 Apr 2020 15:36:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJj9e-0001so-I2 for guix-patches@gnu.org; Wed, 01 Apr 2020 15:36:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55382) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJj9e-0001sf-4K for guix-patches@gnu.org; Wed, 01 Apr 2020 15:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJj9d-0006AG-Vu for guix-patches@gnu.org; Wed, 01 Apr 2020 15:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40274] [PATCH v4] gnu: Add kernel-module-loader-service. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Apr 2020 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40274 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 40274@debbugs.gnu.org Received: via spool by 40274-submit@debbugs.gnu.org id=B40274.158576970423513 (code B ref 40274); Wed, 01 Apr 2020 19:36:01 +0000 Received: (at 40274) by debbugs.gnu.org; 1 Apr 2020 19:35:04 +0000 Received: from localhost ([127.0.0.1]:38695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJj8i-000679-07 for submit@debbugs.gnu.org; Wed, 01 Apr 2020 15:35:04 -0400 Received: from pelzflorian.de ([5.45.111.108]:44070 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJj8f-00066Z-FE for 40274@debbugs.gnu.org; Wed, 01 Apr 2020 15:35:02 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id D32F0360566; Wed, 1 Apr 2020 21:34:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1585769699; bh=QDmaB+GSKAZlGE+vC6Dgez2syiHJoToV4ot+9XCvzVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=WDGxpKGZM40S4FgqzWfM48mHrZ246lZEFR/9eMQL6QSvtf6+5fWgx772zDyeLVm9f OYM8phiXC0Y/2WdeeYgffd8/DUoYJ2Z0BGFkY2tF8QPz9PVOWDQ52Pj7ATIB4Ww6hp 7jrPNHBTxs8DsOu3xWwAQmP9iQnHHuIC23rZas8U= Date: Wed, 1 Apr 2020 21:34:58 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20200401193458.evg46ygamtniby7k@pelzflorian.localdomain> References: <20200328135908.2540-1-brice@waegenei.re> <20200331202340.10054-1-brice@waegenei.re> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200331202340.10054-1-brice@waegenei.re> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Thank you for your patch. I tried with your patch to make the Guix install image load the uvesafb kernel module, but it fails and I get no log. Is it possible to make the service log failures? I just get: failed to load service: kernel-module-loader printed on the console (but not to /var/log/messages). I believe I pass parameters wrongly. I attach how I try to use your kernel-module-loader. Regards, Florian diff --git a/gnu/system/install.scm b/gnu/system/install.scm index c15c2c7814..aa42449098 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -26,11 +26,13 @@ #:use-module (gnu bootloader u-boot) #:use-module (guix gexp) #:use-module (guix store) + #:use-module (guix utils) #:use-module (guix monads) #:use-module ((guix packages) #:select (package-version)) #:use-module ((guix store) #:select (%store-prefix)) #:use-module (gnu installer) #:use-module (gnu services dbus) + #:use-module (gnu services linux) #:use-module (gnu services networking) #:use-module (gnu services shepherd) #:use-module (gnu services ssh) @@ -50,6 +52,7 @@ #:use-module (gnu packages texinfo) #:use-module (gnu packages compression) #:use-module (gnu packages nvi) + #:use-module (gnu packages xorg) #:use-module (ice-9 match) #:use-module (srfi srfi-26) #:export (installation-os @@ -304,7 +307,8 @@ Access documentation at any time by pressing Alt-F2.\x1b[0m (define bare-bones-os (load "examples/bare-bones.tmpl")) - (list (service virtual-terminal-service-type) + (cons* + (service virtual-terminal-service-type) (service kmscon-service-type (kmscon-configuration @@ -408,7 +412,13 @@ Access documentation at any time by pressing Alt-F2.\x1b[0m (list bare-bones-os glibc-utf8-locales texinfo - (canonical-package guile-2.2)))))) + (canonical-package guile-2.2))) + (if (member (%current-system) '("x86_64-linux" "i686-linux")) + ;; Load uvesafb to show installer when no KMS is available. + `(,(kernel-module-loader-service + '(("uvesafb" (string-append "v86d=" #$v86d "/sbin/v86d") + "mode_option=1024x768")))) + '())))) (define %issue ;; Greeting.