From patchwork Sun Mar 15 21:06:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Baines X-Patchwork-Id: 20700 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 723B827BBEB; Sun, 15 Mar 2020 21:34:15 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 4BD4E27BBEA for ; Sun, 15 Mar 2020 21:34:15 +0000 (GMT) Received: from localhost ([::1]:59130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDati-0007rJ-Iy for patchwork@mira.cbaines.net; Sun, 15 Mar 2020 17:34:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33455) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDaTQ-0005lO-8x for guix-patches@gnu.org; Sun, 15 Mar 2020 17:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDaTP-000891-9c for guix-patches@gnu.org; Sun, 15 Mar 2020 17:07:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDaTP-00088F-64 for guix-patches@gnu.org; Sun, 15 Mar 2020 17:07:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDaTP-0000B2-1G for guix-patches@gnu.org; Sun, 15 Mar 2020 17:07:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#38754] [PATCH 1/4] lint: Add a requires-store? field to the checker record. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Mar 2020 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38754@debbugs.gnu.org Received: via spool by 38754-submit@debbugs.gnu.org id=B38754.1584306397619 (code B ref 38754); Sun, 15 Mar 2020 21:07:02 +0000 Received: (at 38754) by debbugs.gnu.org; 15 Mar 2020 21:06:37 +0000 Received: from localhost ([127.0.0.1]:35706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDaSz-00009q-6S for submit@debbugs.gnu.org; Sun, 15 Mar 2020 17:06:37 -0400 Received: from mira.cbaines.net ([212.71.252.8]:36342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDaSw-000097-9b for 38754@debbugs.gnu.org; Sun, 15 Mar 2020 17:06:35 -0400 Received: from localhost (unknown [46.237.160.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 5DA5427BBE4 for <38754@debbugs.gnu.org>; Sun, 15 Mar 2020 21:06:33 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id dbed325b for <38754@debbugs.gnu.org>; Sun, 15 Mar 2020 21:06:31 +0000 (UTC) From: Christopher Baines Date: Sun, 15 Mar 2020 21:06:28 +0000 Message-Id: <20200315210631.5334-1-mail@cbaines.net> X-Mailer: git-send-email 2.25.0 In-Reply-To: <87lfqsxsxn.fsf@gnu.org> References: <87lfqsxsxn.fsf@gnu.org> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches This can then be used to mark checkers that require a store connection, which will enable passing a connection in, avoiding the overhead of establishing a connection inside the check function when it's run for lots of different packages. * guix/lint.scm (): Add requires-store? to the record type. --- guix/lint.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index 24fbf05202..2a084382c6 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -100,7 +100,8 @@ lint-checker? lint-checker-name lint-checker-description - lint-checker-check)) + lint-checker-check + lint-checker-requires-store?)) ;;; @@ -155,7 +156,9 @@ ;; 'certainty' level. (name lint-checker-name) (description lint-checker-description) - (check lint-checker-check)) + (check lint-checker-check) + (requires-store? lint-checker-requires-store? + (default #f))) (define (properly-starts-sentence? s) (string-match "^[(\"'`[:upper:][:digit:]]" s))