| Message ID | 20200226113442.9798-1-mail@ambrevar.xyz |
|---|---|
| Headers | show |
Pierre Neidhardt <mail@ambrevar.xyz> writes: > Update ghc-pandoc to 2.92 and rename it to pandoc. > This closes bug 33844. > > Questions: > > - Should this go on staging? It rebuilds a few hundred packages, maybe less > than 300. > - I'm not 100% sure that updating the Haskell libraries didn't break > anything. I guess the continuous integration will tell us. > - 3-4 libraries seemed to have many dependents and updating them would break > stuff, so instead I created a versioned package, e.g. ghc-regex-base-0.94. > Is this OK? Is there a best practice here? I would prefer to untangle upgrading any packages from renaming ghc-pandoc to pandoc. Haskell package upgrades need to be consistent according to the current LTS. We can’t just upgrade some Haskell packages without upgrading them all. They also cannot be upgraded to the latest version as that may be higher than the LTS version. -- Ricardo
Ricardo Wurmus <rekado@elephly.net> writes: >> - Should this go on staging? It rebuilds a few hundred packages, maybe less >> than 300. >> - I'm not 100% sure that updating the Haskell libraries didn't break >> anything. I guess the continuous integration will tell us. >> - 3-4 libraries seemed to have many dependents and updating them would break >> stuff, so instead I created a versioned package, e.g. ghc-regex-base-0.94. >> Is this OK? Is there a best practice here? > > I would prefer to untangle upgrading any packages from renaming > ghc-pandoc to pandoc. No problem. > Haskell package upgrades need to be consistent according to the current > LTS. We can’t just upgrade some Haskell packages without upgrading them > all. They also cannot be upgraded to the latest version as that may be > higher than the LTS version. I'm new to Haskell packaging. Where do I find the LTS versions? Can we update pandoc then?
Hi Pierre, On Thu, 27 Feb 2020 at 08:52, Pierre Neidhardt <mail@ambrevar.xyz> wrote: > Ricardo Wurmus <rekado@elephly.net> writes: > > Haskell package upgrades need to be consistent according to the current > > LTS. We can’t just upgrade some Haskell packages without upgrading them > > all. They also cannot be upgraded to the latest version as that may be > > higher than the LTS version. > > I'm new to Haskell packaging. Where do I find the LTS versions? > Can we update pandoc then? I am not closely following the Haskell packaging in Guix, but you should find the LTS versions there: https://www.stackage.org/ It is better to upgrade all the Haskell packages (compiler included) to stay compliant with the LTS, otherwise it should become a mess falling in the Cabal Hell. https://en.wikipedia.org/wiki/Cabal_(software)#Criticism Hope that helps. simon
Makes sense, thanks!
Hi Pierre, > Update ghc-pandoc to 2.92 and rename it to pandoc. > This closes bug 33844. We have a stackage importer that can help here. We should update to the latest LTS Haskell release of 15.14. The version of Pandoc in that LTS Haskell release is 2.9.1.1. We will also need a new GHC (8.8.3), and all other Haskell packages need to upgraded together. This could then go to a new branch that we can have ci.guix.gnu.org build for us. I’m about to finish a few changes to the haskell-build-system and our current GHC package to reduce the closure size; that could also go to the same branch. Would you like to help with the update or should we close this issue?
Hi Ricardo, Thanks for the update, looks great! I originally sent this patch because I needed pandoc 2.9.* at some point, but I no longer use it (at least for now) and I'm no Haskeller so my motivation is a bit low to be honest :D If no one else gets to it, I may give this a shot in a while (don't hold your breat) :p I suggest you let know guix-devel, hopefully someone will chime in!
Dear, On Wed, 26 Feb 2020 at 12:34, Pierre Neidhardt <mail@ambrevar.xyz> wrote: > Update ghc-pandoc to 2.92 and rename it to pandoc. Does this patch set [1] still make sense? Especially after the merge [2] of wip-haskell and since the patches are not consistent with LTS, AFAICT. > This closes bug 33844. Almost close by commit d4e4a3824d380e576b56a74aa714db205fcc59a4. [1] http://issues.guix.gnu.org/issue/39798 [2] https://lists.gnu.org/archive/html/guix-devel/2020-08/msg00017.html All the best, simon
zimoun <zimon.toutoune@gmail.com> writes: > > On Wed, 26 Feb 2020 at 12:34, Pierre Neidhardt <mail@ambrevar.xyz> wrote: > >> Update ghc-pandoc to 2.92 and rename it to pandoc. > > Does this patch set [1] still make sense? > Especially after the merge [2] of wip-haskell and since the patches are > not consistent with LTS, AFAICT. The lack of consistency is the biggest problem. Since Pierre has no motivation to continue working on these patches I’d say we should close this issue.
Dear,
>>> Update ghc-pandoc to 2.92 and rename it to pandoc.
Commit d4e4a3824d380e576b56a74aa714db205fcc59a4 adds the package
pandoc. Then couples of commits rename all the dependencies.
Moreover, updating to 2.92 without consistency with Haskell LTS packages
is a problem.
Therefore, I am closing. Feel free to reopen if there is motivation to
continue working on these patches.
All the best,
simon
Closing with the explanations here:
<http://issues.guix.gnu.org/issue/39798#21>
Thanks,
simon