diff mbox series

[bug#39063,3/6] services: pulseaudio-configuration: Set flat-volumes to no.

Message ID 20200110014823.10595-3-leo.prikler@student.tugraz.at
State Accepted
Headers show
Series [bug#39062,1/6] services: Add pulseaudio-configuration. | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Leo Prikler Jan. 10, 2020, 1:48 a.m. UTC 
* gnu/services/sound (pulseaudio-configuration) [daemon-conf]:
Disable flat-volumes.  Enabling flat-volumes, as is the upstream default,
causes unpleasant experiences to users when applications inadvertently max
out the system volume (e.g. as in #38172).
---
 gnu/services/sound.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marius Bakke Jan. 11, 2020, 4:59 p.m. UTC | #1 
Leo Prikler <leo.prikler@student.tugraz.at> writes:

> * gnu/services/sound (pulseaudio-configuration) [daemon-conf]:
> Disable flat-volumes.  Enabling flat-volumes, as is the upstream default,
> causes unpleasant experiences to users when applications inadvertently max
> out the system volume (e.g. as in #38172).

I moved this comment inside the service definition code so that we don't
have to reach for 'git blame' when we forget why it was added.
diff mbox series

Patch

diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 6b2b345a44..5d72b3ada2 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -113,7 +113,7 @@  ctl.!default {
   (client-conf pulseaudio-client-conf
                (default '()))
   (daemon-conf pulseaudio-daemon-conf
-               (default '()))
+               (default '((flat-volumes . no))))
   (script-file pulseaudio-script-file
                (default (file-append pulseaudio "/etc/pulse/default.pa")))
   (system-script-file pulseaudio-system-script-file