| Message ID | 20200109073128.wi5gsntnypxw4dmn@pelzflorian.localdomain |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#39048] Clarify description of the Pagekite service. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | Apply failed |
Hello Alex Griffin, I see that you added the Pagekite service to Guix and am thankful for that and for showing me that Pagekite exists. However I believe users not familiar with setting up servers could think they need Pagekite in cases where configuring their NAT to do port forwarding would be enough. On Thu, Jan 09, 2020 at 08:31:28AM +0100, Florian Pelz wrote: > * doc/guix.texi (Networking Services): Make clear Pagekite is not necessary > with port forwarding. > --- > doc/guix.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index df1ba428a5..2a860db4c8 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -14154,8 +14154,8 @@ Package object of the Open vSwitch. > @defvr {Scheme Variable} pagekite-service-type > This is the service type for the @uref{https://pagekite.net, PageKite} service, > a tunneling solution for making localhost servers publicly visible, even from > -behind NAT or restrictive firewalls. The value for this service type is a > -@code{pagekite-configuration} record. > +behind restrictive firewalls or NAT without forwarded ports. The value for > +this service type is a @code{pagekite-configuration} record. > > Here's an example exposing the local HTTP and SSH daemons: > > -- > 2.24.1 > > > > I propose this change; do you approve? Regards, Florian
Hello Florian Pelz, Looks good to me, go ahead and make the change if you wish!
On Fri, Jan 10, 2020 at 10:40:13PM +0000, Alex Griffin wrote: > Hello Florian Pelz, > > Looks good to me, go ahead and make the change if you wish! > > -- > Alex Griffin Thank you! I added a doc: prefix to the commit message and pushed as f22b35711323a1e101ed666ec5ce776bf1908a74 Regards, Florian
diff --git a/doc/guix.texi b/doc/guix.texi index df1ba428a5..2a860db4c8 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -14154,8 +14154,8 @@ Package object of the Open vSwitch. @defvr {Scheme Variable} pagekite-service-type This is the service type for the @uref{https://pagekite.net, PageKite} service, a tunneling solution for making localhost servers publicly visible, even from -behind NAT or restrictive firewalls. The value for this service type is a -@code{pagekite-configuration} record. +behind restrictive firewalls or NAT without forwarded ports. The value for +this service type is a @code{pagekite-configuration} record. Here's an example exposing the local HTTP and SSH daemons: