From patchwork Tue Jan 7 11:08:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ashish.is--- via Guix-patches\" via" X-Patchwork-Id: 19679 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1E57117A24; Tue, 7 Jan 2020 14:44:34 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id D7F6317A1C for ; Tue, 7 Jan 2020 14:44:33 +0000 (GMT) Received: from localhost ([::1]:50302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioq5x-0006Vu-7n for patchwork@mira.cbaines.net; Tue, 07 Jan 2020 09:44:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35615) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iomjP-0004wz-KO for guix-patches@gnu.org; Tue, 07 Jan 2020 06:09:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iomjO-00061q-6V for guix-patches@gnu.org; Tue, 07 Jan 2020 06:09:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41408) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iomjO-00061m-3t for guix-patches@gnu.org; Tue, 07 Jan 2020 06:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iomjN-0007Rb-Uv for guix-patches@gnu.org; Tue, 07 Jan 2020 06:09:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#39006] [PATCH] gnu: timidity++: Add libvorbis as input Resent-From: EuAndreh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Jan 2020 11:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39006 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 39006@debbugs.gnu.org Cc: EuAndreh X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157839532128579 (code B ref -1); Tue, 07 Jan 2020 11:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2020 11:08:41 +0000 Received: from localhost ([127.0.0.1]:47381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iomj3-0007Qt-AX for submit@debbugs.gnu.org; Tue, 07 Jan 2020 06:08:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:35230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iomj1-0007Ql-7g for submit@debbugs.gnu.org; Tue, 07 Jan 2020 06:08:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35511) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iomiy-0003WH-JW for guix-patches@gnu.org; Tue, 07 Jan 2020 06:08:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iomix-0005ls-6i for guix-patches@gnu.org; Tue, 07 Jan 2020 06:08:36 -0500 Received: from box.euandre.org ([162.243.185.39]:41496) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iomix-0005kx-2r for guix-patches@gnu.org; Tue, 07 Jan 2020 06:08:35 -0500 Received: from authenticated-user (box.euandre.org [162.243.185.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 938F29F718; Tue, 7 Jan 2020 09:08:33 -0200 (-02) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=euandre.org; s=mail; t=1578395314; bh=XLbMrWuTy6UrNulVTFoeCMHO4uXAAr73g9VhJ2FxQC4=; h=From:To:Cc:Subject:Date:From; b=UG7BwuZOq17H5BIOveo+dSu+R1/kVFc7MS82dTyyzr1tkcodEb+Q1DTSej9Sqizcn Fkbj4X/Nm9WHoSp0vh1EdvuhB/Y63G9RzK4z+4kvojBAlratTxNVoKcuIamOKZ4TcN S+Kxf4vo5Ri2uR+d7pLsN9Asin+X5cUkouvipnKDiEpPv17m/Nc33vClbrCf6l9nZV 3pL8TemARRIldZHMrqN8HbYEu0XxkWv0d0YFdHKSqvb/Ijt8gxjFdUqyPmBClIuAR1 Fg1pCZS7TvmKPJqsdtPBumngDdxXnxxIpb8shfBk+ut/vQ8kofPdwmlRBFvgU0XLx9 xgeshDIL4rMtQ== Date: Tue, 7 Jan 2020 08:08:30 -0300 Message-Id: <20200107110830.25890-1-eu@euandre.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-Mailman-Approved-At: Tue, 07 Jan 2020 08:33:51 -0500 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: EuAndreh , EuAndreh via Guix-patches X-Patchwork-Original-From: EuAndreh via Guix-patches via From: "ashish.is--- via Guix-patches\" via" X-getmail-retrieved-from-mailbox: Patches * gnu/packages/audio.scm (timidity++)[inputs] Add libvorbis as input --- Hi Guix! The current definition of TiMidity++ does include the configure flag for Ogg Vorbis (--enable-audio=vorbis), but the package definition does not provide all the required inputs for actually enabling it: --8<---------------cut here---------------start------------->8--- $ guix environment --ad-hoc -- timidity -Ov Playmode `v' is not compiled in. Try timidity -h for help --8<---------------cut here---------------end--------------->8--- From the build log (http://ci.guix.gnu.org/log/qynf65197fp921vz8k03qblz7djaarb0-timidity++-2.14.0): --8<---------------cut here---------------start------------->8--- ... checking for Ogg... yes checking for Vorbis... no *** Could not run Vorbis test program, checking why... *** The test program failed to compile or link. See the file config.log for the *** exact error that occured. This usually means Vorbis was incorrectly installed *** or that you have moved Vorbis since it was installed. ... --8<---------------cut here---------------end--------------->8--- This happens because 'libogg' in provided as input, but 'libvorbis' isn't. After applying this patch, Ogg Vorbis becomes available like other formats. --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix environment --ad-hoc -- timidity -Ov Try timidity -h for help --8<---------------cut here---------------end--------------->8--- gnu/packages/audio.scm | 1 + 1 file changed, 1 insertion(+) -- 2.24.1 diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 55a34460b1..f37ebc886e 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -2574,6 +2574,7 @@ Suil currently supports every combination of Gtk, Qt, and X11.") ("flac" ,flac) ("jack" ,jack-1) ("libogg" ,libogg) + ("libvorbis" ,libvorbis) ("speex" ,speex) ("ncurses" ,ncurses) ("freepats" ,freepats)))