mbox

[bug#38885,WIP,0/4] Update docker.

Message ID 20200103013303.13336-1-dannym@scratchpost.org
Headers show

Message

Danny Milosavljevic Jan. 3, 2020, 1:33 a.m. UTC 
gotestsum ironically has a test failure.

Danny Milosavljevic (4):
  gnu: Add go-golang.org-x-sync-errgroup.
  gnu: Add go-gotest-tools-assert.
  gnu: Add gotestsum.
  gnu: docker: Update to 19.03.5.

 gnu/local.mk                                  |   3 -
 gnu/packages/docker.scm                       |  13 +-
 gnu/packages/golang.scm                       | 100 +++++++++++++
 ...ocker-adjust-tests-for-changes-in-go.patch |  67 ---------
 .../docker-engine-test-noinstall.patch        |  23 ---
 .../patches/docker-use-fewer-modprobes.patch  | 137 ------------------
 6 files changed, 106 insertions(+), 237 deletions(-)
 delete mode 100644 gnu/packages/patches/docker-adjust-tests-for-changes-in-go.patch
 delete mode 100644 gnu/packages/patches/docker-engine-test-noinstall.patch
 delete mode 100644 gnu/packages/patches/docker-use-fewer-modprobes.patch

Comments

Ludovic Courtès Jan. 15, 2020, 9:07 p.m. UTC | #1 
Hello!

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> gotestsum ironically has a test failure.

Oh, does it need further work?

> Danny Milosavljevic (4):
>   gnu: Add go-golang.org-x-sync-errgroup.
>   gnu: Add go-gotest-tools-assert.
>   gnu: Add gotestsum.
>   gnu: docker: Update to 19.03.5.

From a quick glance it all LGTM.  Bonus points if you can wrap lines in
the first patch.  :-)

Thank you!

Ludo’.
Danny Milosavljevic Feb. 10, 2020, 6:02 p.m. UTC | #2 
Hi Ludo,

On Wed, 15 Jan 2020 22:07:23 +0100
Ludovic Courtès <ludo@gnu.org> wrote:

> Oh, does it need further work?

Yeah.  I've done that now (learned a lot about Go API versioning in the process)
and pushed the result to guix master.

go-gotest-tools-assert still has a problem because the formatting
of the assertion errors changed.  I've disabled go-gotest-tools-assert's own
tests (only) for now.

Docker is updated now.  Phiew!