diff mbox series

[bug#38846,3/4] doc: Encourage patch review.

Message ID 20200101163446.5132-3-ludo@gnu.org
State Accepted
Headers show
Series Move 'HACKING' to the manual, and a proposal for commit access | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Ludovic Courtès Jan. 1, 2020, 4:34 p.m. UTC
* doc/contributing.texi (Commit Access): Add note about patch review.
---
 doc/contributing.texi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Ricardo Wurmus Jan. 1, 2020, 6:09 p.m. UTC | #1
Ludovic Courtès <ludo@gnu.org> writes:

> * doc/contributing.texi (Commit Access): Add note about patch review.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index e6e6ab36c2..74b4718eb3 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -1149,3 +1149,9 @@ you're confident, it's OK to commit.
>  
>  That last part is subject to being adjusted, allowing individuals to commit
>  directly on non-controversial changes on parts they’re familiar with.
> +
> +One last thing: the project keeps moving forward because committers not
> +only push their own awesome changes, but also offer some of their time
> +@emph{reviewing} and pushing other people's changes.  As a committer,
> +you're welcome to use your expertise and commit rights to help other
> +contributors, too!

Perfect!
diff mbox series

Patch

diff --git a/doc/contributing.texi b/doc/contributing.texi
index e6e6ab36c2..74b4718eb3 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1149,3 +1149,9 @@  you're confident, it's OK to commit.
 
 That last part is subject to being adjusted, allowing individuals to commit
 directly on non-controversial changes on parts they’re familiar with.
+
+One last thing: the project keeps moving forward because committers not
+only push their own awesome changes, but also offer some of their time
+@emph{reviewing} and pushing other people's changes.  As a committer,
+you're welcome to use your expertise and commit rights to help other
+contributors, too!