mbox

[bug#38301,0/4] Allow for multiple '--manifest' options

Message ID 20191120134213.30753-1-ludo@gnu.org
Headers show

Message

Ludovic Courtès Nov. 20, 2019, 1:42 p.m. UTC 
Hello Guix!

As discussed on guix-devel, this patch series ensures that one can
pass multiple ‘--manifest’ options to ‘guix package’, ‘guix pack’,
and ‘guix environment’ (which already supported it actually!).

Feedback welcome!

Ludo’.

Ludovic Courtès (4):
  environment: Document that '--manifest' can be repeated.
  profiles: Add 'concatenate-manifests'.
  package: Allow multiple '--manifest' options.
  pack: Allow multiple '--manifest' options.

 doc/guix.texi             |  9 ++++---
 guix/profiles.scm         |  5 ++++
 guix/scripts/pack.scm     | 17 +++++++++----
 guix/scripts/package.scm  | 50 ++++++++++++++++++++-------------------
 tests/guix-environment.sh | 23 ++++++++++++++++++
 tests/guix-pack.sh        | 11 +++++++++
 tests/guix-package.sh     | 13 ++++++++++
 tests/profiles.scm        |  5 ++++
 8 files changed, 101 insertions(+), 32 deletions(-)

Comments

Konrad Hinsen Nov. 20, 2019, 4:33 p.m. UTC | #1 
Hi Ludo,

> As discussed on guix-devel, this patch series ensures that one can
> pass multiple ‘--manifest’ options to ‘guix package’, ‘guix pack’,
> and ‘guix environment’ (which already supported it actually!).
>
> Feedback welcome!

Looks good. And very nice to have!

Thanks,
  Konrad.
Simon Tournier Nov. 22, 2019, 2:37 p.m. UTC | #2 
Hi Ludo,

On Wed, 20 Nov 2019 at 17:34, Konrad Hinsen <konrad.hinsen@fastmail.net> wrote:
>
> Hi Ludo,
>
> > As discussed on guix-devel, this patch series ensures that one can
> > pass multiple ‘--manifest’ options to ‘guix package’, ‘guix pack’,
> > and ‘guix environment’ (which already supported it actually!).
> >
> > Feedback welcome!

Neat!

The test guix-pack fails but because I am trying to use "git worktree"
so maybe I am doing something wrong.
I am investigating in tests-suite.log.


Cheers,
simon