diff mbox series

[bug#37962] gnu: emacs-evil: Remove undo-tree dependency.

Message ID 20191028153435.5076-1-clement@lassieur.org
State Accepted
Headers show
Series [bug#37962] gnu: emacs-evil: Remove undo-tree dependency. | expand

Commit Message

Clément Lassieur Oct. 28, 2019, 3:34 p.m. UTC
Because it is buggy and unnecessary.  See
<https://github.com/emacs-evil/evil/issues/1074>.

* gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
emacs-undo-tree and emacs-goto-chg.
---
 gnu/packages/emacs-xyz.scm | 3 ---
 1 file changed, 3 deletions(-)

Comments

Clément Lassieur Oct. 28, 2019, 3:43 p.m. UTC | #1
The idea is that if people need it, they can install it and it'll just
work, but I personnaly don't want 'u' to be bound to undo-tree because
it has unfixed bugs that can lead to data loss[1].

'r' won't work anymore, but C-/ can be used instead[2].

Cheers,
Clément

[1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
[2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948
Clément Lassieur Oct. 28, 2019, 3:50 p.m. UTC | #2
clement@lassieur.org (Clément Lassieur) writes:

> The idea is that if people need it, they can install it and it'll just
> work, but I personnaly don't want 'u' to be bound to undo-tree because
> it has unfixed bugs that can lead to data loss[1].
>
> 'r' won't work anymore, but C-/ can be used instead[2].

I meant C-r (undo-tree-redo).

>
> Cheers,
> Clément
>
> [1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
> [2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948
Mathieu Othacehe Oct. 29, 2019, 7:43 a.m. UTC | #3
Hello Clément,

This LGTM!

Thanks,

Mathieu

Clément Lassieur writes:

> Because it is buggy and unnecessary.  See
> <https://github.com/emacs-evil/evil/issues/1074>.
>
> * gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
> emacs-undo-tree and emacs-goto-chg.
> ---
>  gnu/packages/emacs-xyz.scm | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 688206452e..ba8ece1e22 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")
>          (base32
>           "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
>      (build-system emacs-build-system)
> -    (propagated-inputs
> -     `(("emacs-undo-tree" ,emacs-undo-tree)
> -       ("emacs-goto-chg" ,emacs-goto-chg)))
>      (home-page "https://github.com/emacs-evil/evil")
>      (synopsis "Extensible Vi layer for Emacs")
>      (description
Clément Lassieur Oct. 29, 2019, 10:07 a.m. UTC | #4
thanks!  Pushed.
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 688206452e..ba8ece1e22 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7418,9 +7418,6 @@  news items, openrc and runscripts.")
         (base32
          "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
     (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-undo-tree" ,emacs-undo-tree)
-       ("emacs-goto-chg" ,emacs-goto-chg)))
     (home-page "https://github.com/emacs-evil/evil")
     (synopsis "Extensible Vi layer for Emacs")
     (description