| Message ID | 20190929155728.27777-1-mail@cbaines.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#37553] inferior: Change to use the (guix repl) module. | expand |
Hi, Christopher Baines <mail@cbaines.net> skribis: > Rather than (guix scripts repl), from which the machine-repl procedure was > removed in [1]. > > 1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679 > > * guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix > scripts repl). > --- > guix/inferior.scm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/guix/inferior.scm b/guix/inferior.scm > index dcbc954432..d6d2053ab8 100644 > --- a/guix/inferior.scm > +++ b/guix/inferior.scm > @@ -136,8 +136,8 @@ it's an old Guix." > (object->string > `(begin > (primitive-load ,(search-path %load-path > - "guix/scripts/repl.scm")) > - ((@ (guix scripts repl) machine-repl)))))) > + "guix/repl.scm")) > + ((@ (guix repl) machine-repl)))))) > pipe))) This one LGTM! (Note that this code is only used when spawning an inferior for a revision that dates back to before ‘guix repl’ existed, so before July 2018.) Thanks, Ludo’.
Ludovic Courtès <ludo@gnu.org> writes: > Hi, > > Christopher Baines <mail@cbaines.net> skribis: > >> Rather than (guix scripts repl), from which the machine-repl procedure was >> removed in [1]. >> >> 1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679 >> >> * guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix >> scripts repl). >> --- >> guix/inferior.scm | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/guix/inferior.scm b/guix/inferior.scm >> index dcbc954432..d6d2053ab8 100644 >> --- a/guix/inferior.scm >> +++ b/guix/inferior.scm >> @@ -136,8 +136,8 @@ it's an old Guix." >> (object->string >> `(begin >> (primitive-load ,(search-path %load-path >> - "guix/scripts/repl.scm")) >> - ((@ (guix scripts repl) machine-repl)))))) >> + "guix/repl.scm")) >> + ((@ (guix repl) machine-repl)))))) >> pipe))) > > This one LGTM! Great :) I've pushed it as 2cd599f005bb91ae120a66824b8efbac81a27a69. > (Note that this code is only used when spawning an inferior for a > revision that dates back to before ‘guix repl’ existed, so before July > 2018.) Yep, I've been experimenting with loading older revisions in to the Guix Data Service, and this is one of the issues I came across.
Hi, Christopher Baines <mail@cbaines.net> skribis: > Yep, I've been experimenting with loading older revisions in to the Guix > Data Service, and this is one of the issues I came across. Nice! I’ve been thinking we should have time-traveling continuous integration. Like checking that we can build some Guix revision of the past in between two ‘core-updates’ merges. It would also be useful to flag known-bad revisions, but in a way the Data Service is already doing that for recent revisions. Thanks, Ludo’.
Ludovic Courtès <ludo@gnu.org> writes: > Hi, > > Christopher Baines <mail@cbaines.net> skribis: > >> Yep, I've been experimenting with loading older revisions in to the Guix >> Data Service, and this is one of the issues I came across. > > Nice! I’ve been thinking we should have time-traveling continuous > integration. Like checking that we can build some Guix revision of the > past in between two ‘core-updates’ merges. > > It would also be useful to flag known-bad revisions, but in a way the > Data Service is already doing that for recent revisions. So I've been looking at retrying failed jobs in the Guix Data Service, there are a few where it's just networking issues talking to Savannah. I guess it could be useful to have a list of revisions which can't be used through guix pull or a channel, and that information could also be used in the Guix Data Service.
Hi Chris, Christopher Baines <mail@cbaines.net> skribis: > Ludovic Courtès <ludo@gnu.org> writes: > >> Hi, >> >> Christopher Baines <mail@cbaines.net> skribis: >> >>> Yep, I've been experimenting with loading older revisions in to the Guix >>> Data Service, and this is one of the issues I came across. >> >> Nice! I’ve been thinking we should have time-traveling continuous >> integration. Like checking that we can build some Guix revision of the >> past in between two ‘core-updates’ merges. >> >> It would also be useful to flag known-bad revisions, but in a way the >> Data Service is already doing that for recent revisions. > > So I've been looking at retrying failed jobs in the Guix Data Service, > there are a few where it's just networking issues talking to Savannah. Cool. > I guess it could be useful to have a list of revisions which can't be > used through guix pull or a channel, and that information could also be > used in the Guix Data Service. Yes, thanks for looking into it! Ludo’.
diff --git a/guix/inferior.scm b/guix/inferior.scm index dcbc954432..d6d2053ab8 100644 --- a/guix/inferior.scm +++ b/guix/inferior.scm @@ -136,8 +136,8 @@ it's an old Guix." (object->string `(begin (primitive-load ,(search-path %load-path - "guix/scripts/repl.scm")) - ((@ (guix scripts repl) machine-repl)))))) + "guix/repl.scm")) + ((@ (guix repl) machine-repl)))))) pipe))) (define* (port->inferior pipe #:optional (close close-port))