diff mbox series

[bug#37457] gnu: Add makeself-safeextract.

Message ID 20190919103552.1415-1-mail@ambrevar.xyz
State Accepted
Headers show
Series [bug#37457] gnu: Add makeself-safeextract. | expand

Commit Message

Pierre Neidhardt Sept. 19, 2019, 10:35 a.m. UTC 
* gnu/packages/compression.scm (makeself-safeextract): New variable.
---
 gnu/packages/compression.scm | 49 +++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

Comments

Ludovic Courtès Sept. 26, 2019, 9:09 p.m. UTC | #1 
Hello,

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> * gnu/packages/compression.scm (makeself-safeextract): New variable.

[...]

> +      (synopsis "Extract makeself and mojo archives without running untrusted code")
> +      (description "A simple script to unpack makeself-generated
> +self-extractors without running the possibly untrusted shell script.")

What about:

  This package provides a script to unpack self-extracting archives
  generated by @command{makeself} or @command{mojo} without running the
  possibly untrusted extraction shell script.

?

(I didn’t know about these things.)

Otherwise LGTM, thanks!

Ludo’.
Pierre Neidhardt Sept. 27, 2019, 7:58 a.m. UTC | #2 
Done, thanks!
Ricardo Wurmus Sept. 27, 2019, 8:01 p.m. UTC | #3 
Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Done, thanks!

Thanks, closing.
Pierre Neidhardt Sept. 27, 2019, 8:07 p.m. UTC | #4 
Ricardo Wurmus <rekado@elephly.net> writes:

> Thanks, closing.

Hmm?  I had already closed it, hadn't I?
I received a confirmation from control@debbugs.gnu.org.

--8<---------------cut here---------------start------------->8---
Processing commands for control@debbugs.gnu.org:

> close 37457
bug#37457: [PATCH] gnu: Add makeself-safeextract.
bug closed, send any further explanations to
37457@debbugs.gnu.org and Pierre Neidhardt <mail@ambrevar.xyz>

> quit
Stopping processing here.
--8<---------------cut here---------------end--------------->8---
Ricardo Wurmus Sept. 27, 2019, 9:58 p.m. UTC | #5 
Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Thanks, closing.
>
> Hmm?  I had already closed it, hadn't I?
> I received a confirmation from control@debbugs.gnu.org.

Oh, my bad.  I only saw a last email without message to
*-done@debbugs.gnu.org; didn’t stop to check the current status of the
issue first.

--
Ricardo
diff mbox series

Patch

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index bda43bfd18..9785fa7a60 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -22,7 +22,7 @@ 
 ;;; Copyright © 2017 Julien Lepiller <julien@lepiller.eu>
 ;;; Copyright © 2018 Rutger Helling <rhelling@mykolab.com>
 ;;; Copyright © 2018 Joshua Sierles, Nextjournal <joshua@nextjournal.com>
-;;; Copyright © 2018 Pierre Neidhardt <mail@ambrevar.xyz>
+;;; Copyright © 2018, 2019 Pierre Neidhardt <mail@ambrevar.xyz>
 ;;; Copyright © 2019 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -48,6 +48,7 @@ 
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages autotools)
@@ -2000,3 +2001,49 @@  external compressors: the compressor to be used for each format is configurable
 at run time, and must be installed separately.")
     (license (list license:bsd-2        ; arg_parser.{cc,h}
                    license:gpl2+))))    ; the rest
+
+(define-public makeself-safeextract
+  (let ((commit "1a95e121fa8e3c02d307ae37b9b7834e616c3683"))
+    (package
+      (name "makeself-safeextract")
+      (version (git-version "0.0.0" "1" commit))
+      (home-page "https://github.com/ssokolow/makeself_safeextract")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url home-page)
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1anlinaj9lvfi8bn00wp11vzqq0f9sig4fm9yrspisx31v0z4a2c"))))
+      (build-system trivial-build-system)
+      (inputs
+       `(("python" ,python-2)
+         ("p7zip" ,p7zip)
+         ("unzip" ,unzip)))
+      (arguments
+       `(#:modules ((guix build utils))
+         #:builder
+         (begin
+           (use-modules (guix build utils))
+           (let* ((name "makeself_safeextract")
+                  (source (string-append (assoc-ref %build-inputs "source")
+                                         "/" name ".py"))
+                  (bin (string-append (assoc-ref %outputs "out") "/bin"))
+                  (target (string-append bin "/" name))
+                  (python (string-append (assoc-ref %build-inputs "python") "/bin"))
+                  (7z (string-append (assoc-ref %build-inputs "p7zip") "/bin/7z"))
+                  (unzip (string-append (assoc-ref %build-inputs "unzip") "/bin/unzip")))
+             (setenv "PATH" (string-append (getenv "PATH") ":" python))
+             (mkdir-p bin)
+             (copy-file source target)
+             (substitute* target
+               (("'7z'") (format #f "'~a'" 7z))
+               (("'unzip'") (format #f "'~a'" unzip)))
+             (patch-shebang target)))))
+      (synopsis "Extract makeself and mojo archives without running untrusted code")
+      (description "A simple script to unpack makeself-generated
+self-extractors without running the possibly untrusted shell script.")
+      (license license:gpl3+))))