From patchwork Mon Sep 2 15:33:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Othacehe X-Patchwork-Id: 15255 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CA1211734D; Mon, 2 Sep 2019 16:38:14 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 79DAD17329 for ; Mon, 2 Sep 2019 16:38:14 +0100 (BST) Received: from localhost ([::1]:37666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4oPF-0005Fm-MT for patchwork@mira.cbaines.net; Mon, 02 Sep 2019 11:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42929) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4oMU-0002Vm-Mu for guix-patches@gnu.org; Mon, 02 Sep 2019 11:35:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4oMT-00054x-5W for guix-patches@gnu.org; Mon, 02 Sep 2019 11:35:22 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i4oMT-00054N-1k for guix-patches@gnu.org; Mon, 02 Sep 2019 11:35:21 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i4oMQ-0006g2-FM for guix-patches@gnu.org; Mon, 02 Sep 2019 11:35:19 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#36477] [PATCH v3 46/48] system: vm: Support cross-compilation. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Sep 2019 15:35:18 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36477 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 36477@debbugs.gnu.org Received: via spool by 36477-submit@debbugs.gnu.org id=B36477.156743849625379 (code B ref 36477); Mon, 02 Sep 2019 15:35:18 +0000 Received: (at 36477) by debbugs.gnu.org; 2 Sep 2019 15:34:56 +0000 Received: from localhost ([127.0.0.1]:58835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4oM3-0006bF-LP for submit@debbugs.gnu.org; Mon, 02 Sep 2019 11:34:56 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:45300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4oLk-0006XN-BK for 36477@debbugs.gnu.org; Mon, 02 Sep 2019 11:34:36 -0400 Received: by mail-wr1-f52.google.com with SMTP id q12so14413477wrj.12 for <36477@debbugs.gnu.org>; Mon, 02 Sep 2019 08:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DKHYqcz+TrJYHtYnh41O9JXkw/xT0ZpMscZMzyf8MRU=; b=mijFHR7PYP7DzRoc6Rozrt0ETKVox82YjLzwIQLw0QJwsu7HmrEYt5D+nfUJojcyNw NK6Y0ksPNRdMrkqPPay0HSe7tyoOdBKaBtnZvVJb5ggcc3DlZp/dXjhhy2aWJVxJNFaJ y+EdkZ4fadfqUnOxAoRv7odFrR7/RA3myZ6Uxy8ZHX0IhmOH8k40cnZKMNCL6idhpdrm +of2kvUph1iEU5si2opH32SJ5JGbYIHZCW0AAGDSsKdVoyYty2Q2eoe9bf7NVdW/Ck4/ UDvgMVphaTsoCeZ4NYQk/U1SSKxRuflVq3Q69N70xsusi7uKOnOoNoAoNJH/cIRFVAhh rM2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DKHYqcz+TrJYHtYnh41O9JXkw/xT0ZpMscZMzyf8MRU=; b=jcz7YlPIpz5D8OEclGFcrT7SoQyh3ugN1SdazFRPlXd49av4dnRZtba9P+2w43wuwN MbTGIrJPBFzgmZmNEaZzwfn20xQwpcWTJPUCw6V+8w4iNm2Qb0qL4JJNWZc0GECu7g3a yyn6p+yZZ1SRMUaOiAdQ5w3E7W+0dymC7x7UlWMA2JKE2va1NSQBQU21PhiTqLwanDmi L/Ofu7rR6+11wHJPANEFhTTwS3j+GPBreZIZX3HvlDKyfCmx8zB4gp7odvLpm/sJH6xI aYNJxb0LaPUFU1axWQFvC6CTkq7iL63zGfgd8URQ4Ma9JpqKuiaHMwxVk9HBDBgeejgs vGJQ== X-Gm-Message-State: APjAAAV1cvNMu2kzAe+LRg0WlJrmi6Yv58kFW4KSEYIRPSXAQjcC9PwV abVEPW06KRfUbmFSIkjDxA/i+K4z X-Google-Smtp-Source: APXvYqwVhcrhsy9h+VEm8kkNE7yOoOu7frVPF98/+SbrqFt0/z8hq3gGkuqAuso06pu0w9hSSbq/zg== X-Received: by 2002:a5d:6a49:: with SMTP id t9mr2416794wrw.134.1567438470460; Mon, 02 Sep 2019 08:34:30 -0700 (PDT) Received: from localhost.localdomain ([80.12.63.115]) by smtp.gmail.com with ESMTPSA id b26sm17232265wmj.14.2019.09.02.08.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2019 08:34:29 -0700 (PDT) From: Mathieu Othacehe Date: Mon, 2 Sep 2019 17:33:31 +0200 Message-Id: <20190902153333.11190-47-m.othacehe@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190902153333.11190-1-m.othacehe@gmail.com> References: <20190902153333.11190-1-m.othacehe@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Othacehe Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/system.scm (system-linux-image-file-name): Add support for cross-built systems. Remove system argument that was ignored, (operating-system-kernel-file): adapt by removing ignored os argument. * gnu/system/vm.scm (expression->derivation-in-linux-vm): Add target argument, move qemu from inputs list to a new native-inputs list and adapt set-path-environment-variable call accordingly. Pass target to qemu-command and gexp->derivation calls. (iso9660-image): Move qemu from inputs to a new native-inputs list and adapt set-path-environment-variable accordingly. (qemu-image): Add target argument, move qemu from inputs list to a new native-inputs list and adapt set-path-environment-variable call accordingly. Pass target argument to expression->derivation-in-linux-vm call. --- gnu/system.scm | 15 ++++++++------- gnu/system/vm.scm | 25 ++++++++++++++++++------- 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index 485896ba0a..85059119cc 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -439,20 +439,21 @@ from the initrd." "Return the list of swap services for OS." (map swap-service (operating-system-swap-devices os))) -(define* (system-linux-image-file-name #:optional (system (%current-system))) +(define* (system-linux-image-file-name) "Return the basename of the kernel image file for SYSTEM." ;; FIXME: Evaluate the conditional based on the actual current system. - (cond - ((string-prefix? "arm" (%current-system)) "zImage") - ((string-prefix? "mips" (%current-system)) "vmlinuz") - ((string-prefix? "aarch64" (%current-system)) "Image") - (else "bzImage"))) + (let ((target (or (%current-target-system) (%current-system)))) + (cond + ((string-prefix? "arm" target) "zImage") + ((string-prefix? "mips" target) "vmlinuz") + ((string-prefix? "aarch64" target) "Image") + (else "bzImage")))) (define (operating-system-kernel-file os) "Return an object representing the absolute file name of the kernel image of OS." (file-append (operating-system-kernel os) - "/" (system-linux-image-file-name os))) + "/" (system-linux-image-file-name))) (define* (operating-system-directory-base-entries os) "Return the basic entries of the 'system' directory of OS for use as the diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 07cee2d4f5..759745c277 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -143,7 +143,7 @@ (define* (expression->derivation-in-linux-vm name exp #:key - (system (%current-system)) + (system (%current-system)) target (linux linux-libre) initrd (qemu qemu-minimal) @@ -214,7 +214,8 @@ made available under the /xchg CIFS share." (use-modules (guix build utils) (gnu build vm)) - (let* ((inputs '#$(list qemu (canonical-package coreutils))) + (let* ((inputs '#$(list (canonical-package coreutils))) + (native-inputs '#+(list qemu)) (linux (string-append #$linux "/" #$(system-linux-image-file-name))) (initrd #$initrd) @@ -222,16 +223,19 @@ made available under the /xchg CIFS share." (graphs '#$(match references-graphs (((graph-files . _) ...) graph-files) (_ #f))) + (target #$(or (%current-target-system) (%current-system))) (size #$(if (eq? 'guess disk-image-size) #~(+ (* 70 (expt 2 20)) ;ESP (estimated-partition-size graphs)) disk-image-size))) - (set-path-environment-variable "PATH" '("bin") inputs) + (set-path-environment-variable "PATH" '("bin") + (append inputs native-inputs)) (load-in-linux-vm loader #:output #$output #:linux linux #:initrd initrd + #:qemu (qemu-command target) #:memory-size #$memory-size #:make-disk-image? #$make-disk-image? #:single-file-output? #$single-file-output? @@ -248,6 +252,7 @@ made available under the /xchg CIFS share." (gexp->derivation name builder ;; TODO: Require the "kvm" feature. #:system system + #:target target #:env-vars env-vars #:guile-for-build guile-for-build #:references-graphs references-graphs))) @@ -299,9 +304,10 @@ INPUTS is a list of inputs (as for packages)." (setlocale LC_ALL "en_US.utf8") (let ((inputs - '#$(append (list qemu parted e2fsprogs dosfstools xorriso) + '#$(append (list parted e2fsprogs dosfstools xorriso) (map canonical-package (list sed grep coreutils findutils gawk)))) + (native-inputs '#+(list qemu)) (graphs '#$(match inputs @@ -315,7 +321,8 @@ INPUTS is a list of inputs (as for packages)." ((name thing output) `(,thing ,output))) inputs))) - (set-path-environment-variable "PATH" '("bin" "sbin") inputs) + (set-path-environment-variable "PATH" '("bin" "sbin") + (append inputs native-inputs)) (make-iso9660-image #$xorriso '#$grub-mkrescue-environment #$(bootloader-package bootloader) @@ -346,6 +353,7 @@ INPUTS is a list of inputs (as for packages)." (define* (qemu-image #:key (name "qemu-image") (system (%current-system)) + (target (%current-target-system)) (qemu qemu-minimal) (disk-image-size 'guess) (disk-image-format "qcow2") @@ -404,9 +412,10 @@ system." (setlocale LC_ALL "en_US.utf8") (let ((inputs - '#$(append (list qemu parted e2fsprogs dosfstools) + '#$(append (list util-linux parted e2fsprogs dosfstools) (map canonical-package (list sed grep coreutils findutils gawk)))) + (native-inputs '#+(list qemu)) ;; This variable is unused but allows us to add INPUTS-TO-COPY ;; as inputs. @@ -416,7 +425,8 @@ system." ((name thing output) `(,thing ,output))) inputs))) - (set-path-environment-variable "PATH" '("bin" "sbin") inputs) + (set-path-environment-variable "PATH" '("bin" "sbin") + (append inputs native-inputs)) (let* ((graphs '#$(match inputs (((names . _) ...) @@ -483,6 +493,7 @@ system." #:bootloader-installer #$(bootloader-installer bootloader))))))) #:system system + #:target target #:make-disk-image? #t #:disk-image-size disk-image-size #:disk-image-format disk-image-format