diff mbox series

[bug#36755] gnu: mallard-ducktype: Update to 1.0.2.

Message ID 20190722000800.28933-1-jackhill@jackhill.us
State Accepted
Headers show
Series [bug#36755] gnu: mallard-ducktype: Update to 1.0.2. | expand

Commit Message

Jack Hill July 22, 2019, 12:08 a.m. UTC 
With this release a source tarball is newly available on PyPI.

* gnu/packages/python-xyz.scm (mallard-ducktype) Update to 1.0.2.
[source] Use pypi uri.
---
 gnu/packages/python-xyz.scm | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

Comments

Efraim Flashner July 22, 2019, 6:50 a.m. UTC | #1 
The patch applies cleanly but it turns out the test suite doesn't run.
Digging a little further, the test suite isn't included with the pypi
release, so I'd prefer to stay with the git checkout so we can run the
test suite.

Can you send an updated patch that keeps the git checkout?

Thanks
Jack Hill July 22, 2019, 1:27 p.m. UTC | #2 
On Mon, 22 Jul 2019, Efraim Flashner wrote:

> The patch applies cleanly but it turns out the test suite doesn't run.
> Digging a little further, the test suite isn't included with the pypi
> release, so I'd prefer to stay with the git checkout so we can run the
> test suite.

Thanks for the review and catching that. I agree that sticking with the 
git checkout sounds like the correct course of action.

> Can you send an updated patch that keeps the git checkout?

Sure, new patch coming shortly.
diff mbox series

Patch

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 6e90c9a933..43bcc377e7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3122,19 +3122,14 @@  and is very extensible.")
 (define-public mallard-ducktype
   (package
     (name "mallard-ducktype")
-    (version "1.0.1")
+    (version "1.0.2")
     (source
      (origin
-       (method git-fetch)
-       ;; git-reference because a proper source tarball is not available
-       ;; https://lists.gnu.org/archive/html/guix-devel/2019-05/msg00209.html
-       (uri (git-reference
-             (url "https://github.com/projectmallard/mallard-ducktype.git")
-             (commit version)))
-       (file-name (git-file-name name version))
+       (method url-fetch)
+       (uri (pypi-uri name version))
        (sha256
         (base32
-         "0crland0kmpsyjfmnflcw7gaqy5b87b6ah17cmr9d5z1kyazf54n"))))
+         "1xxx8jqsqais91li2wl9jbc9fzhgq1gbi24lf9kx43j6fjck25cf"))))
     (build-system python-build-system)
     (home-page "http://projectmallard.org")
     (synopsis "Convert Ducktype to Mallard documentation markup")